change default for process checks in core agent

[brycekahle]

What does this PR do?

Re-apply of #33434 with fixed tests

Motivation

Describe how you validated your changes

Additional test failures were due to now faulty assumption that process-agent is always running.

Possible Drawbacks / Trade-offs

Additional Notes

[buraizu]

Approving with a minor update requested for the release note

[arbll]

I'm not sure I follow why both this and the removal of units assertions are needed ? My understanding is that enabling this setting should lead to the previous behavior and require no extra changes

[brycekahle]

This only applies to this specific test

[brycekahle]

This PR changes it so process checks run in core agent by default on Linux, and thus process-agent will not be running. It will start up but then exit because it isn't needed.

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57097283 --os-family=ubuntu

Note: This applies to commit 1c39865

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor e1841bcbca0b8f1e31fd87bfcd6dc75b4ebdbea5

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-arm64-deb	0.01MB	⚠️	808.85MB	808.84MB	0.50MB
datadog-agent-aarch64-rpm	0.01MB	⚠️	818.62MB	818.62MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	827.66MB	827.66MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	827.66MB	827.66MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	817.87MB	817.87MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.33MB	59.33MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	443.28MB	443.28MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.02MB	62.02MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.27MB	59.27MB	0.50MB

Decision

⚠️ Warning

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	791.78MiB	801.8MiB	192.63MiB	202.62MiB
✅	static_quality_gate_agent_deb_arm64	783.16MiB	793.14MiB	174.59MiB	184.51MiB
✅	static_quality_gate_agent_rpm_amd64	791.64MiB	801.79MiB	195.03MiB	205.03MiB
✅	static_quality_gate_agent_rpm_arm64	783.02MiB	793.09MiB	176.43MiB	186.44MiB
✅	static_quality_gate_agent_suse_amd64	791.67MiB	801.81MiB	195.03MiB	205.03MiB
✅	static_quality_gate_agent_suse_arm64	783.02MiB	793.14MiB	176.43MiB	186.44MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.67MiB	9.78MiB	19.78MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.27MiB	46.27MiB	8.48MiB	18.49MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.67MiB	9.79MiB	19.79MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.88MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.59MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.6MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	876.13MiB	886.12MiB	294.21MiB	304.21MiB
✅	static_quality_gate_docker_agent_arm64	890.79MiB	900.79MiB	280.47MiB	290.47MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.06GiB	369.32MiB	379.33MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.06GiB	351.58MiB	361.55MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.81MiB	55.78MiB	17.28MiB	27.28MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	54.45MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.95MiB	274.78MiB	106.34MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.91MiB	290.82MiB	101.18MiB	111.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3f58fead-df7f-487b-8d8a-0665272022ed

Baseline: e1841bc
Comparison: 1c39865
Diff

Optimization Goals: ✅ Improvement(s) detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	file_tree	memory utilization	-10.17	[-10.22, -10.12]	1	Logs
✅	quality_gate_idle	memory utilization	-19.15	[-19.18, -19.12]	1	Logs bounds checks dashboard

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+1.79	[+1.72, +1.87]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+1.48	[+1.42, +1.53]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.20	[-0.57, +0.98]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.05	[-0.79, +0.88]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.62, +0.66]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.78, +0.80]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.03, +0.04]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.63, +0.63]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.86, +0.84]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.80, +0.77]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.30, +0.26]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.20	[-0.66, +0.26]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.27	[-2.13, -0.40]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.89	[-5.78, -0.01]	1	Logs
✅	file_tree	memory utilization	-10.17	[-10.22, -10.12]	1	Logs
✅	quality_gate_idle	memory utilization	-19.15	[-19.18, -19.12]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.