Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ws) Add export map and esm entrypoint #57234

Merged
merged 1 commit into from
Nov 29, 2021
Merged

(ws) Add export map and esm entrypoint #57234

merged 1 commit into from
Nov 29, 2021

Conversation

weswigham
Copy link
Contributor

This mirrors the export map and esm entrypoint provided by ws at runtime.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 17, 2021

@weswigham Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 11 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 57234,
  "author": "weswigham",
  "headCommitOid": "60c9163e88c317f7399fde0e5dcedc4fa6ce9cb1",
  "lastPushDate": "2021-11-17T21:23:57.000Z",
  "lastActivityDate": "2021-11-29T18:06:45.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "ws",
      "kind": "edit",
      "files": [
        {
          "path": "types/ws/OTHER_FILES.txt",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt)"
        },
        {
          "path": "types/ws/index.d.mts",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/ws/package.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) (check: `exports`)"
        }
      ],
      "owners": [
        "loyd",
        "mlamp",
        "TitaneBoy",
        "reduckted",
        "teidesu",
        "wojtkowiak",
        "k-yle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 972054694,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Check Config Changes a module config files labels Nov 17, 2021
@typescript-bot
Copy link
Contributor

🔔 @loyd @mlamp @TitaneBoy @reduckted @teidesu @wojtkowiak @k-yle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Nov 29, 2021
@typescript-bot
Copy link
Contributor

Re-ping @loyd, @mlamp, @TitaneBoy, @reduckted, @teidesu, @wojtkowiak, @k-yle:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@sandersn
Copy link
Contributor

@weswigham From what I understand of esm export maps, this is correct and won't break existing uses. So should I merge this?

@weswigham
Copy link
Contributor Author

I was hoping one of the maintainers would show up, but yeah.

@sandersn sandersn merged commit 0fc29f4 into master Nov 29, 2021
@sandersn sandersn deleted the ws-export-map branch November 29, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files Critical package Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants