Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect argument parsing in PING command for IronHawk engine #1434

Open
SeanChinJunKai opened this issue Jan 30, 2025 · 4 comments
Open

Incorrect argument parsing in PING command for IronHawk engine #1434

SeanChinJunKai opened this issue Jan 30, 2025 · 4 comments
Assignees

Comments

@SeanChinJunKai
Copy link
Contributor

SeanChinJunKai commented Jan 30, 2025

Image

The above inputs to the PING command should be seen as a single argument however it results in wrong number of arguments error

@SeanChinJunKai SeanChinJunKai changed the title Incorrect argument parsing in PING command due to string.Fields behavior Incorrect argument parsing in PING command due to string.Fields behavior for IronHawk engine Jan 30, 2025
@SeanChinJunKai SeanChinJunKai changed the title Incorrect argument parsing in PING command due to string.Fields behavior for IronHawk engine Incorrect argument parsing in PING command for IronHawk engine Jan 30, 2025
@lucifercr07
Copy link
Contributor

lucifercr07 commented Jan 30, 2025

Thanks @SeanChinJunKai for reporting, will check this.

@SeanChinJunKai can you please confirm once if you're using the IronHawk engine or the other one.

@SeanChinJunKai
Copy link
Contributor Author

@lucifercr07 I think we can use something similar to the old engine by parsing it into []interface{} and using switch cases to evaluate the type

@SeanChinJunKai
Copy link
Contributor Author

@lucifercr07 this is on ironhawk engine

@lucifercr07 lucifercr07 self-assigned this Jan 30, 2025
@lucifercr07
Copy link
Contributor

Truncation still happens on ironhawk engine with latest dicedb-cli version. Have raised PR here to fix this.

Not observed an issue with dicedb as such with latest commit on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants