You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We reimplemented the core of the DiceDB engine and re-wrote - the wire protocol, execution engine, and config management. This rewrite helped us gain 32% throughput over our existing benchmark.
To make DiceDB stable even after 100s of changes, we have to put effort
into making sure we have a comprehensive integration test suite for each command. This issue will be used to cover the port and fixes for integration tests related to the command DEL.
Here are the pre-requisite
setup DiceDB server locally from the source - instructions
setup DiceDB Go SDK locally from the source - instructions
refer to the Pointing to local checked-out dicedb-gosection inREADME`.
Start the DiceDB server with IronHawk engine
$ go run main.go --engine ironhawk --log-level debug
Setting up Integration Tests
Make sure the DiceDB server is running. This is essential for you to run the tests
Integration tests of all the commands can be found under tests/commands/ironhawk with the name del_test.go.
For the command DEL find the tests
Run the test function using the following command
$ TEST_FUNC=^TestSet$ make test-one
Replace the name of the function with whatever the name is in your del_test.go file.
Note the ^ and $ in the TEST_FUNC variable. It is a regex and this way, the command
executes only one function which is TestSet.
Things need to be done
Fix any dependency error (refer set_test.go file)
Fix any execution error (refer set_test.go file)
There are some utility functions written, use them, but as per the set_test.go file.
Ideally, all the tests should pass. If some are failing
either fix them (if you think it is a bug in the tests)
or raise a bug if you think there is an implementation mistake
Eventually, we need 100% integration test coverage for all the commands to
prove that DiceDB is stable and production-ready.
If you find any other bug while you are implementing it, you can either
We reimplemented the core of the DiceDB engine and re-wrote - the wire protocol, execution engine, and config management. This rewrite helped us gain 32% throughput over our existing benchmark.
To make DiceDB stable even after 100s of changes, we have to put effort
into making sure we have a comprehensive integration test suite for each command. This issue will be used to cover the port and fixes for integration tests related to the command
DEL
.Here are the pre-requisite
Pointing to local checked-out
dicedb-gosection in
README`.Start the DiceDB server with IronHawk engine
Setting up Integration Tests
tests/commands/ironhawk
with the namedel_test.go
.DEL
find the testsReplace the name of the function with whatever the name is in your
del_test.go
file.Note the
^
and$
in theTEST_FUNC
variable. It is a regex and this way, the commandexecutes only one function which is
TestSet
.Things need to be done
set_test.go
file)set_test.go
file)set_test.go
file.Ideally, all the tests should pass. If some are failing
Eventually, we need 100% integration test coverage for all the commands to
prove that DiceDB is stable and production-ready.
If you find any other bug while you are implementing it, you can either
Follow the contribution guidelines
These are general guidelines to follow before you submit a patch. Please mark them as done
once you complete them
make lint
on your local copy of the codebaseThe text was updated successfully, but these errors were encountered: