Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Dark Theme support #12484

Closed
typhoon71 opened this issue Sep 6, 2017 · 9 comments
Closed

Dark Theme support #12484

typhoon71 opened this issue Sep 6, 2017 · 9 comments
Assignees

Comments

@typhoon71
Copy link

Using ta dark theme (in ffox or the OS itself) makes this addon on click menu in the unreadable: can something be done about this?
Thanks.

@cowlicks
Copy link
Contributor

Can you share which theme you are using and which version of FF? It looks ok to me with FF 56 and this theme https://addons.mozilla.org/en-US/firefox/addon/dark-background-light-text/?src=search

@typhoon71
Copy link
Author

Firefox 55.0.3, TTDeepdark latest.
The theme is a complete theme, but the issue with the menu appears in https averywhere only.
I'd be really happy id it get fixed... In case this addon doesn't die later this year with ffox 57.
It's already being flagged as "obsolete" on ffox 55, so I guess devs aren't that thrilled.

@Octav14n
Copy link

I have a dark UI theme on Ubuntu (installing the above suggested Firefox-theme would be easier)
I have installed the latest WebExtension version of HTTPS-Everywhere and have the same issue.

@Carm01
Copy link

Carm01 commented Sep 22, 2017

FT Deepdark causes issues with me as well, cannot see anything 14.4.5

@typhoon71
Copy link
Author

typhoon71 commented Sep 23, 2017

I'd like to point out that the problem isn't really on TTDeepdark, but more on what "element" is used by HTTPS-Everywhere addon to "draw" text the menu.
As you can see in the attacched images, both noscript and firefox menu play nicely with custom themes, while HTTPS-Everywhere doesn't.

noscript
immagine

firefox menu
immagine

HTTPS-Everywhere
immagine

@JPRuehmann
Copy link

I have the same Problem.
Whill be a Fix in the near Future?
Thanks

@rugk
Copy link
Contributor

rugk commented Apr 27, 2019

Actually, with Firefox 67 and above, all this will be is possible with https://developer.mozilla.org/docs/Web/CSS/@media/prefers-color-scheme.

And maybe you are in the soon future "forced" to add a dark theme for your options page, at least. See #17841 for details.

@pipboy96
Copy link
Contributor

I will release a PR for this issue soon.

@pipboy96 pipboy96 added the hold label Apr 29, 2019
@pipboy96
Copy link
Contributor

Closing until dark mode add-ons page will be available at least in Beta or Developer Edition version, hopefully this will be fixed upstream. Also, by default even if you select Dark theme, dark add-on page and dark versions of other pages won't be enabled unless you enable dark mode in your OS or set ui.systemUsesDarkTheme to 1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants