Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Refactoring #898

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

sdavis-amido
Copy link
Contributor

4750 - Remove Domain Behaviour on Entities

πŸ“² What

Refactor domain behaviour to service class

πŸ€” Why

Better separation of concerns

πŸ›  How

See ADR

πŸ‘€ Evidence

N/A

πŸ•΅οΈ How to test

mvn clean test

βœ… Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@sdavis-amido
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdavis-amido
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.2% 86.2% Coverage
0.0% 0.0% Duplication

@sdavis-amido sdavis-amido merged commit 966f0e0 into master Jul 26, 2022
@sdavis-amido sdavis-amido deleted the feature/4750-Refactor-away-domain-behaviour branch July 26, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant