-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8157 remove cypress nx generator - DO NOT MERGE UNTIL V2.0.7 published with deprecation notice #324
base: main
Are you sure you want to change the base?
Conversation
…ight. (confirmed in files packages\playwright\)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will give this a proper review in the morning. But immediately I'd say we do not want to delete our cypress generator. We're just removing support for it, as such it needs to be marked as deprecated in documentation (i.e the Cypress plugin readme and official stacks docs).
So the only deletions we should be doing is where we have the option to scaffold something with Cypress.
…r tests on pipeline test
DO NOT MERGE until
https://github.com/Ensono/stacks-nx-plugins/actions/runs/11551312478 published to npm as v 2.0.7
📲 What
I want to remove the nx generator for Cypress tests
🤔 Why
Cypress is no longer supported within Stacks so we need to remove it from the NX Generator plugins.
🛠 How
These are the folders containing the cypress plugin: - remove
https://github.com/Ensono/stacks-nx-plugins/tree/main/packages/cypress
https://github.com/Ensono/stacks-nx-plugins/tree/main/e2e/cypress-e2e
This is the documentation that refers to the Cypress plugin - update
[https://github.com/Ensono/stacks-nx-plugins/blob/main/CONTRIBUTING.md?plain=1#L135]
Update other files that have references to Cypress - these will include e2e, configuration type files.
👀 Evidence
Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR
🕵️ How to test
Notes for QA
✅ Acceptance criteria Checklist