Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8157 remove cypress nx generator - DO NOT MERGE UNTIL V2.0.7 published with deprecation notice #324

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ninjagirl888
Copy link
Contributor

@ninjagirl888 ninjagirl888 commented Oct 21, 2024

DO NOT MERGE until

https://github.com/Ensono/stacks-nx-plugins/actions/runs/11551312478 published to npm as v 2.0.7

📲 What

I want to remove the nx generator for Cypress tests

🤔 Why

Cypress is no longer supported within Stacks so we need to remove it from the NX Generator plugins.

🛠 How

These are the folders containing the cypress plugin: - remove
https://github.com/Ensono/stacks-nx-plugins/tree/main/packages/cypress
https://github.com/Ensono/stacks-nx-plugins/tree/main/e2e/cypress-e2e

This is the documentation that refers to the Cypress plugin - update
[https://github.com/Ensono/stacks-nx-plugins/blob/main/CONTRIBUTING.md?plain=1#L135]

Update other files that have references to Cypress - these will include e2e, configuration type files.

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR

🕵️ How to test

Notes for QA

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

Copy link
Member

@Danphillipz Danphillipz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will give this a proper review in the morning. But immediately I'd say we do not want to delete our cypress generator. We're just removing support for it, as such it needs to be marked as deprecated in documentation (i.e the Cypress plugin readme and official stacks docs).

So the only deletions we should be doing is where we have the option to scaffold something with Cypress.

@ninjagirl888 ninjagirl888 changed the title 8157 remove cypress nx generator 8157 remove cypress nx generator - DO NOT MERGE UNTIL V2.0.7 published with deprecation notice Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants