Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation] Prevent double border when slotted in Shell #7088

Open
Tracked by #7180
macandcheese opened this issue Jun 1, 2023 · 1 comment
Open
Tracked by #7180

[Navigation] Prevent double border when slotted in Shell #7088

macandcheese opened this issue Jun 1, 2023 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2025-05-13 - 3.2....

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jun 1, 2023 •
edited by geospatialem
Loading

Description

Currently, when slotted within Shell, a double border occurs with other slotted elements in the content area:
Screen Shot 2023-06-01 at 4 21 17 PM

Acceptance Criteria

Follow same pattern as panel where variable removes the border when slotted in shell.

Screen Shot 2023-06-01 at 4 21 40 PM

Relevant Info

No response

Which Component

Navigation / Shell

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 1, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Jun 1, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. design-tokens Issues requiring design tokens. and removed needs triage Planning workflow - pending design/dev review. labels Apr 30, 2024
@geospatialem
Copy link
Member

Could make the token available internally, and use a border-inset invert, such as -1 to invert the look in the component when slotted in shell.

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem mentioned this issue Aug 27, 2024
Open
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2025-05-13 - 3.2.0 May Main Release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP