Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: should a collapsed panel's header have a border bottom? #8726

Open
Tracked by #7180
driskull opened this issue Feb 10, 2024 · 0 comments
Open
Tracked by #7180

Panel: should a collapsed panel's header have a border bottom? #8726

driskull opened this issue Feb 10, 2024 · 0 comments
Labels
0 - new New issues that need assignment. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - design - sm Small design effort; 1-4 days of design work p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Milestone
Design Backlog

Comments

@driskull
Copy link
Member

Background

should a collapsed panel's header have a border bottom?

When a panel is collapsed, I would expect there not to be a border-bottom set on the header. In the Maps SDK, we use a CSS var to remove it so that it is not shown here:

image

theres also a double border when collapsed and a footer is present.

image

This may also be an issue for blocks

image

Desired Outcome

Cleanup of the border on the header when a component is collapsed.
@driskull driskull added design Issues that need design consultation prior to development. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. design-tokens Issues requiring design tokens. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Feb 10, 2024
@brittneytewks brittneytewks added p - low Issue is non core or affecting less that 10% of people using the library estimate - design - sm Small design effort; 1-4 days of design work and removed needs triage Planning workflow - pending design/dev review. labels Mar 4, 2024
@brittneytewks brittneytewks added this to the Design Backlog milestone Mar 4, 2024
@geospatialem geospatialem mentioned this issue Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - design - sm Small design effort; 1-4 days of design work p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Milestone
Design Backlog
Development

No branches or pull requests
2 participants
@driskull @brittneytewks