[$250] Update electron-builder package to latest version

[MitchExpensify]

Action Performed:

Check which version of electron builder is here. (You can csee what version we are using by running the command npm list ejs)

Expected Result:

The version used by Expensify should match the latest version listed here

Actual Result:

Expensify currently uses electron-builder version 22.13.1

Workaround:

na

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

View all open jobs on GitHub"

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MitchExpensify]

Hey @Christinadobrzyn! This issue was discussed here as likely a great external candidate

[Christinadobrzyn]

Just running this past eng per our triage workflow! If it's good for a contributor please add the External label!

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Gonals]

I think it can be!

[Christinadobrzyn]

I think the original post has all the needed information for the contributor (thanks Mitch!) so created job in Upwork

• Internal job posting - https://www.upwork.com/ab/applicants/1552305715407474688/job-details
• External job positing - https://www.upwork.com/jobs/~018f65f7ebd618c2c9

waiting for proposals!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dennismunene]

PROPOSAL :

Bumping the version in package.json should do the trick.

App/package.json

Line 154 in 53bff65

"electron-builder": "^22.13.1",

to

    "electron-builder": "23.3.1",

You should still be able to run & build the desktop app.
npm run desktop - run desktop app
npm run desktop-build-staging - build desktop app

[parasharrajat]

Ok. I see. This is straightforward. I like @dennismunene's proposal. You will have to provide the following on the PR.

1. Changelog in a comment.
2. Research data if upgrading has affected any of the features that we are using.
3. Test videos and steps for all the things that depend on this.

Do then the app signing. It should not break.

cc: @Beamanator

🎀 👀 🎀 C+ reviewed

[Beamanator]

Agreed with the requirements mentioned by @parasharrajat ^ - let's do this!

[melvin-bot]

📣 @dennismunene You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dennismunene]

Raised PR #10159

[Christinadobrzyn]

Hired @dennismunene for the fix in Upwork ($250)
Hired @parasharrajat as the C+ in Upwork ($250)

PR in review - #10159

[Christinadobrzyn]

working on the PR

[Beamanator]

Technically PR was merged, just waiting for it to be deployed :D

[Beamanator]

Not overdue

[Beamanator]

@Christinadobrzyn I believe this is ready to be paid out and closed! It was mentioned here that the changes worked, in production 👍

[Christinadobrzyn]

Thanks @Beamanator!

• Paid @dennismunene $250 for the job & @parasharrajat $250 as C+ in Upwork.
• Closed job in Upwork
• Closing this GH as complete