Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - There are two offline messages in final page of the send money IOU flow #10261

Closed
kavimuru opened this issue Aug 5, 2022 · 8 comments
Closed
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Aug 5, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Sign into an account on NewDot.
  2. Turn off your WiFi.
  3. Click FAB> Send money
  4. Complete until the final page of the flow

Expected Result:

There must be one offline message in the page

Actual Result:

There are two offline messages in IOU and loading spinner appears in the button

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: v1.1.88-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/183098206-389b4dff-e40c-45fe-8c6b-0d9b31017e9f.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Aug 5, 2022
@kavimuru kavimuru changed the title iOS - There are two offline messages in IOU iOS - There are two offline messages in final page of the send money IOU flow Aug 5, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Aug 5, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@tgolen
Copy link
Contributor

tgolen commented Aug 5, 2022

@Julesssss do you have any insight into this problem?

@tgolen
Copy link
Contributor

tgolen commented Aug 5, 2022

hm, he is offline. @marcaaron or @yuwenmemon do you have any idea who was working on this area?

@marcaaron
Copy link
Contributor

I think it might be this:

  • We added the page wrapper that will now show the offline message in many places cc @jasperhuangg
  • The red message that is displaying here is a random implementation from a much older issue

@Julesssss Julesssss self-assigned this Aug 8, 2022
@Julesssss
Copy link
Contributor

Julesssss commented Aug 8, 2022

Looking into this. Did anyone else manage to reproduce this? Because I'm seeing the expected behavior now on my physical iPhone 7 (matching all other platforms).

Offline UI shown
IMG_0076 IMG_B1B6C846FFA6-1

Version
IMG_0077

@Julesssss Julesssss added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Aug 8, 2022
@Julesssss
Copy link
Contributor

I'll leave the issue open for a moment, just in case this is reproducible with additional steps that I missed. But I'll remove it as a deploy blocker.

@Julesssss
Copy link
Contributor

I'm going to close this. If anyone reading this can reproduce it, please re-open, uncheck the checklist box and share the exact device and steps you took.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants