Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11795] [$250] Invite new members to workspace text-input is not focused - Reported by @aneequeahmad #10587

Closed
mvtglobally opened this issue Aug 26, 2022 · 44 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Planning Changes still in the thought process

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Click on use icon to open setting page.
  2. Click on workspace > manage members > invite .

Expected Result:

Search field of invite new members should be focused.

Actual Result:

Search field is not focused

Workaround:

unknown.

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.91-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-08-25.at.7.31.24.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661437929132899

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 26, 2022

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@varshamb
Copy link
Contributor

varshamb commented Aug 26, 2022

Proposal

In WorkspaceInvite page autoFocus for OptionsSelector is false. Making it true will fix this issue.

<OptionsSelector
autoFocus={false}

@neil-marcellini
Copy link
Contributor

Closing this because that's the expected behavior. See my slack comment here. If we agree it's a bug in the future then we can re-open this.

@neil-marcellini
Copy link
Contributor

Re-opening because the Slack discussion is ongoing and there's some good points there.

@neil-marcellini
Copy link
Contributor

I think this would be a good external issue, but we should hold on implementation until we decide what to do in Slack.

@neil-marcellini neil-marcellini added Planning Changes still in the thought process and removed Daily KSv2 labels Aug 26, 2022
@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 29, 2022
@neil-marcellini neil-marcellini removed their assignment Aug 29, 2022
@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 Overdue labels Oct 18, 2022
@zanyrenney
Copy link
Contributor

@neil-marcellini it looks like we landed on doing nothing for now. Please can you confirm your thoughts as you said hold until we decide in slack... Thanks!

@zanyrenney
Copy link
Contributor

oops! didn't mean to close with that comment.

@neil-marcellini
Copy link
Contributor

I don't think we have talked about it anymore since then. I don't see anything from a quick Slack search. We could close this or make it Monthly again.

@mountiny
Copy link
Contributor

Checked in with Zany on this one, it is an old issue and not reproducible in staging/prod anymore so we are good to close it 🎉

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 9, 2023
@neil-marcellini
Copy link
Contributor

Ditto

@neil-marcellini
Copy link
Contributor

Holding still

@melvin-bot melvin-bot bot removed the Overdue label Apr 10, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@neil-marcellini
Copy link
Contributor

#11795 is being actively worked on, we're still holding here.

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@neil-marcellini
Copy link
Contributor

Same update

@melvin-bot melvin-bot bot removed the Overdue label Jun 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2023
@neil-marcellini
Copy link
Contributor

Still on hold, but there's progress on the issue.

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@zanyrenney
Copy link
Contributor

Still on hold, latest is here- #11795

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@zanyrenney
Copy link
Contributor

Still on hold, latest is here- #11795

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2023
@neil-marcellini
Copy link
Contributor

neil-marcellini commented Oct 10, 2023

@zanyrenney This has already been fixed. It was brought to my attention in Slack here, and after testing it I can confirm it's fixed.

Screen.Recording.2023-10-10.at.12.40.38.PM.mov

@zanyrenney
Copy link
Contributor

As per @neil-marcellini comment above, and the fix being handled elsewhere, closing this one out!

@aneequeahmad
Copy link
Contributor

@zanyrenney i think reporting bonus payment is yet to be paid for this issue.

@aneequeahmad
Copy link
Contributor

@zanyrenney any update on the payment?

@aneequeahmad
Copy link
Contributor

@zanyrenney Just a friendly reminder. Bug reporter payment is still pending for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Planning Changes still in the thought process
Projects
None yet
Development

No branches or pull requests

8 participants