[Bug] iOS - Offline - Stuck comments occur after queued comments send on return from offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Run NewDot App
2. Open any DM chat and turn network off
3. Send few messages and turn network on
4. Send and receive some messages

Expected Result:

The user should be able to send messages while offline, they should be delivered correctly once network restored

Actual Result:

Messages that were sent while offline are stuck at the very bottom. New messages are displayed in the wrong position or not displayed at all

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.92.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/187032408-df2220ff-0494-481c-b791-d71e55f67b26.mp4
https://user-images.githubusercontent.com/93399543/187032413-eaa567ec-78b8-4855-840f-6df23fcf6a85.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[arosiclair]

cc @roryabraham @marcaaron @danieldoglas

Would our new NumberUtils.rand64() IDs usage affect the ordering of comments like this?

[danieldoglas]

@arosiclair the ordering could be related since this deploy was reverted and we'll deploy it again today.

But I've also tested locally and it looks like we're trying to do the write requests even when we're offline, which is strange, so It might be something else too!

[marcaaron]

Would our new NumberUtils.rand64() IDs usage affect the ordering of comments like this?

No, because we are still ordering by sequenceNumber or clientID IIRC.

Are we sure these aren't just "stuck comments" i.e. comments that were created in the server but a Pusher update never received? We've seen that happen recently.

[marcaaron]

Looking at the video and I am 99% sure that's what is happening... see how the comments are not just out of order but duplicated as well...

[marcaaron]

There is no issue with ordering seems like the ordering works just stuck comments.

[arosiclair]

Hmm thanks for the insights. It seems like these optimistic comments might always have the highest sequenceNumber. I'll attempt to repro this and see if I can dig in further

[danieldoglas]

@arosiclair maybe this is related? #10524

[melvin-bot]

@arosiclair Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

@arosiclair Let's hold on this one, as it's related to a design doc on sequenceNumbers that @roryabraham and @tylerkaraszewski are working on.

[arosiclair]

maybe this is related? #10524

It does look like this issue was also occurring in the video above (no offline indicator after enabling airplane mode) so I'd like to see that problem resolved before looking into this.

[arosiclair]

Still on hold

[arosiclair]

Still on hold.

@roryabraham you said you wouldn't mind picking up an issue like this since you're working on killing sequence numbers?

[mallenexpensify]

For reference, from #expensify-open-source - link

Many duplicate messages showing on the sender side, but not receiver. Tough to reproduce

[mallenexpensify]

@arosiclair , here's the tracking issue for deprecating sequence numbers https://github.com/Expensify/Expensify/issues/227234

[JmillsExpensify]

Oh hahaha. Gotcha, yeah I experience this bug still a decent amount. I agree that it's going to get fixed by sequence numbers, but I'd rather keep it open so that it's clear to the community that this is a long-known existing bug and any future reports are duplicates. I'll take the work of commenting weekly.

[stitesExpensify]

Sounds like a plan!

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[JmillsExpensify]

This is still a sporadic issue. Keeping the issue open and on hold.

[JmillsExpensify]

Still holding.

[JmillsExpensify]

Removed iPad from the title since that's not officially supported, though we're still waiting on the Sequence Numbers.

[JmillsExpensify]

Still waiting on sequence numbers.

[JmillsExpensify]

Still held on sequence numbers.

[stitesExpensify]

Not overdue, I'm unsure why Jason's comment didn't remove the label...

[JmillsExpensify]

Woah yeah that's pretty weird.

[JmillsExpensify]

Still on hold for sequence numbers but hopefully that'll we'll be unblocked soon and can circle back on testing.

[JmillsExpensify]

Held on sequence numbers.

[JmillsExpensify]

On hold Melvin. "Hold" your horses.

[JmillsExpensify]

Still on hold for SN.

[JmillsExpensify]

Removing hold and re-testing.

[JmillsExpensify]

Unable to reproduce now. Closing and adding the reproduction label.