Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - All inputs aren't grayed out when switched to offline and no offline indication message too #10666

Closed
kavimuru opened this issue Aug 29, 2022 · 3 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing #10400

Action Performed:

  1. Open App and login
  2. Go offline
  3. Update the workspace name

Expected Result:

All inputs should be grayed out when the Desktop App is offline.

Actual Result:

None of the inputs are grayed out when the Desktop App is offline and no message about it.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: v1.1.93-4
Reproducible in staging?: y
Reproducible in production?: Y ( Its a new feature, so infinite loading when switched to offline in production)
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5709590_offline

Bug5709590_off.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal tester
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jasperhuangg
Copy link
Contributor

@neil-marcellini Looks like this is related to #10400, gonna assign ya

@jasperhuangg jasperhuangg added the Improvement Item broken or needs improvement. label Aug 30, 2022
@neil-marcellini
Copy link
Contributor

The only problem here is that the app is not detecting when were are going offline, so I'm going to close this and keep the offline indicator issue open #10524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

3 participants