Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Chat - Display mode switches from portrait to landscape when turning phone horizontally #11767

Closed
kbecciv opened this issue Oct 12, 2022 · 2 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Oct 12, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #9143

Action Performed:

  1. Go to https://staging.new.expensify.com/ and login
  2. Open any chat
  3. Turn the phone to horizontal position

Expected Result:

According to iPhone requirements for PR 9143 (link https://youtu.be/kuv9in8vtbk and attached videos) nothing should happen upon turning device.

Actual Result:

iPhone switches to landscape mode from portrait mode upon turning device with chat opened, which is not expected.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.2.13.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5773688_IMG_2670.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@AndrewGable
Copy link
Contributor

So I am not sure I agree that this is a bug and I think it warrants a larger discussion on how we want to handle rotation. I agree that the PR said it should not rotate, but I think it's fine that it is rotating for now. Closing for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants