Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting payment 22nd Jan] [$2000] Text duplicated when using voice dictation in form fields (i.e profile > display name) #17174

Closed
1 of 6 tasks
kavimuru opened this issue Apr 8, 2023 · 69 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@kavimuru
Copy link

kavimuru commented Apr 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Click on settings
  2. Click on profile
  3. Click on edit name
  4. Click the native Apple microphone icon and dictate a first name
  5. Click the native Apple microphone again to end the dictation session

Expected Result:

The word dictated should only appear once as text.

Actual Result:

The text gets duplicated

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native - iPhone SE2020
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1680878525.MP4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680908051128159

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f3efde20809bda43
  • Upwork Job ID: 1646235992926674944
  • Last Price Increase: 2023-05-03
Issue OwnerCurrent Issue Owner: @trjExpensify
@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 8, 2023
@MelvinBot
Copy link

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@trjExpensify trjExpensify changed the title Text duplicated when using voice dictation Text duplicated when using voice dictation in form fields (i.e profile > display name) Apr 11, 2023
@trjExpensify trjExpensify removed the Needs Reproduction Reproducible steps needed label Apr 11, 2023
@trjExpensify
Copy link
Contributor

👋 back from OoO, sorry for the slight delay!

Interesting one. Voice to text I would think comes under accessibility issues, and we're not addressing those now. That said, voice to text in chat messages is working fine on iOS native for me, and this bug seems isolated to form fields in places like profile, the workspace name etc, so I actually wonder if it's a bug with forms specifically?

CC: @luacmartins @JmillsExpensify for a second opinion.

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2023
@luacmartins
Copy link
Contributor

Doesn't seem to be specific to Form, since I see the same behavior with OptionsSelector in the NewChatPage for example

@trjExpensify
Copy link
Contributor

since I see the same behavior with OptionsSelector in the NewChatPage for example

Interesting. I can't reproduce the duplication on iOS native in the OptionSelector, only in the forms. Got a vid?

RPReplay_Final1681304570.MP4

@luacmartins
Copy link
Contributor

Here you go

IMG_9681.MOV

@trjExpensify
Copy link
Contributor

Ah hm, what's the diff? Are you clicking the microphone button in the bottom right or that tooltip popover thing?

Anyhow, it seems like this needs to be investigated and it can be external.

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Apr 12, 2023
@melvin-bot melvin-bot bot changed the title Text duplicated when using voice dictation in form fields (i.e profile > display name) [$1000] Text duplicated when using voice dictation in form fields (i.e profile > display name) Apr 12, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01f3efde20809bda43

@MelvinBot
Copy link

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 12, 2023
@MelvinBot
Copy link

Triggered auto assignment to @Beamanator (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@luacmartins
Copy link
Contributor

I tap the bottom right microphone in the keyboard and then it shows up again inline to stop the recording, which is what duplicates the message.

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2023
@hoangzinh
Copy link
Contributor

It seems an upstream bug
I couldn't reproduce too, although my simulator is 16.4

@fedirjh
Copy link
Contributor

fedirjh commented Apr 16, 2023

Not overdue, waiting for proposals.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 16, 2023
@trjExpensify
Copy link
Contributor

Still waiting, going to pop this on monthly.

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@trjExpensify trjExpensify added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2023
@trjExpensify
Copy link
Contributor

Samesies!

@melvin-bot melvin-bot bot removed the Overdue label Oct 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2023
@trjExpensify
Copy link
Contributor

@fedirjh where can we conclusively check the progress on the new release?

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Nov 14, 2023

where can we conclusively check the progress on the new release?

It's still in RC phase.

@fedirjh
Copy link
Contributor

fedirjh commented Nov 15, 2023

The RN upgrade process in our App will be handled here, so we can keep track of the progress in that issue :

@trjExpensify trjExpensify changed the title [HOLD #18121, react-native#37188] [$2000] Text duplicated when using voice dictation in form fields (i.e profile > display name) [HOLD #31381 #18121, react-native#37188] [$2000] Text duplicated when using voice dictation in form fields (i.e profile > display name) Nov 15, 2023
@trjExpensify
Copy link
Contributor

Nice! Added that to the issue title for safe keeps.

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@trjExpensify
Copy link
Contributor

0.73 upgrade is in progress: #31558

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
@trjExpensify
Copy link
Contributor

Okay, #31558 is through the door. So I think we're done here? We only need to pay @esh-g $250 (grandfathered rate for the time of issue creation) for reporting the issue. Correct?

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@trjExpensify trjExpensify added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jan 22, 2024
@trjExpensify trjExpensify changed the title [HOLD #31381 #18121, react-native#37188] [$2000] Text duplicated when using voice dictation in form fields (i.e profile > display name) [Awaiting payment 22nd Jan] [$2000] Text duplicated when using voice dictation in form fields (i.e profile > display name) Jan 22, 2024
@trjExpensify
Copy link
Contributor

@esh-g sent you an offer!

@esh-g
Copy link
Contributor

esh-g commented Jan 26, 2024

@trjExpensify Sorry for the delay! Accepted the offer now

@melvin-bot melvin-bot bot added the Overdue label Jan 26, 2024
@trjExpensify
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests