Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Hold for payment 2024-02-22][TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript #31925

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 17 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/home/report/withReportAndPrivateNotesOrNotFound.js 16
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01adb29124384badba
  • Upwork Job ID: 1760898210657161216
  • Last Price Increase: 2024-02-23
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 21, 2023
@pac-guerreiro
Copy link
Contributor

I am Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this job!

Copy link
Author

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@cubuspl42
Copy link
Contributor

PR #34014 is ready for review by @cristipaval. Automatic assignment failed.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 13, 2024
Copy link
Author

melvin-bot bot commented Feb 13, 2024

@cubuspl42
Copy link
Contributor

PR reviewed and merged 🚀

@kadiealexander kadiealexander changed the title [TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript [Hold for payment 2024-02-22][TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript Feb 19, 2024
@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label Feb 23, 2024
Copy link
Author

melvin-bot bot commented Feb 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01adb29124384badba

@melvin-bot melvin-bot bot changed the title [Hold for payment 2024-02-22][TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript [$500] [Hold for payment 2024-02-22][TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript Feb 23, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 23, 2024
Copy link
Author

melvin-bot bot commented Feb 23, 2024

Current assignee @cubuspl42 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 23, 2024
@kadiealexander kadiealexander added Improvement Item broken or needs improvement. and removed Task labels Feb 23, 2024
@kadiealexander kadiealexander added Task and removed Improvement Item broken or needs improvement. Task Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 23, 2024
@kadiealexander
Copy link
Contributor

@cristipaval just confirming - this should be $250 no?

@kadiealexander kadiealexander changed the title [$500] [Hold for payment 2024-02-22][TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript [$250] [Hold for payment 2024-02-22][TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript Feb 23, 2024
Copy link
Author

melvin-bot bot commented Feb 23, 2024

Upwork job price has been updated to $250

@cubuspl42
Copy link
Contributor

For 99.9% this should be $250.

@chintanspandya
Copy link

I would like to contribute my skill to resolve this issue.

Copy link
Author

melvin-bot bot commented Feb 23, 2024

📣 @chintanspandya! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@cubuspl42
Copy link
Contributor

@chintanspandya This issue is solved, and we're just wrapping up the formalities. Please read the contributing guidelines if you'd like to join the Expensify project.

@kadiealexander
Copy link
Contributor

@cubuspl42 please let me know when you've accepted the contract I sent across.

@cubuspl42
Copy link
Contributor

@kadiealexander Accepted 👍

@kadiealexander
Copy link
Contributor

kadiealexander commented Feb 27, 2024

Payouts due:

Upwork job is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants