Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS migration] Migrate ‘storage’ catalog to Typescript (react-native-onyx) #34340

Closed
blazejkustra opened this issue Jan 11, 2024 · 10 comments
Closed

[TS migration] Migrate ‘storage’ catalog to Typescript (react-native-onyx) #34340

blazejkustra opened this issue Jan 11, 2024 · 10 comments
Assignees
@pecanoro @blazejkustra
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@blazejkustra
Copy link
Contributor

Typescript migration (react-native-onyx)

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

lib/storage/…
lib/OnyxCache.js
lib/utils.js
@blazejkustra blazejkustra added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 11, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mountiny mountiny removed the Bug Something is broken. Auto assigns a BugZero manager. label Jan 11, 2024
@mountiny
Copy link
Contributor

Will be handled by agencies

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 16, 2024

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 18, 2024

Still overdue 6 days?! Let's take care of this!

@blazejkustra blazejkustra mentioned this issue Jan 18, 2024
Closed
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2024
@blazejkustra
Copy link
Contributor Author

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@blazejkustra blazejkustra mentioned this issue Feb 12, 2024
Merged
42 tasks
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Feb 12, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 12, 2024

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Overdue labels Feb 12, 2024
@blazejkustra
Copy link
Contributor Author

@pecanoro The PR is ready for your review 😄

@pecanoro
Copy link
Contributor

Ahh yes, I started yesterday and didn't finish it before the end of the day, I will finish it in the next couple of hours

@blazejkustra
Copy link
Contributor Author

Thank you!

@pecanoro pecanoro added the Reviewing Has a PR in review label Feb 13, 2024
@mountiny mountiny added Weekly KSv2 and removed Monthly KSv2 labels Feb 14, 2024
@pecanoro
Copy link
Contributor

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pecanoro pecanoro

@blazejkustra blazejkustra

Labels
Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pecanoro @mountiny @MitchExpensify @blazejkustra