-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate Onyx.js
to Typescript (react-native-onyx)
#34344
Comments
Triggered auto assignment to @stephanieelliott ( |
Will be handled by agencies |
Huh... This is 4 days overdue. Who can take care of this? |
I have no TS migration issues assigned. Can I take it? |
This issue is internal @AnshuAgarwal24 |
6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Okay thanks for informing @fabioh8010 |
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
We still have to migrate other files before starting this one |
Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I'm brave enough to work on this issue! |
We may want to hold this for #37560 – it should add some changes to |
Don't you worry I still have plenty of errors on my draft PR 🙈 |
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Update: I discussed with Rory that it would be best to split this PR into multiple - I'm working on this |
Update: A lot of PRs were merged, I'm preparing the last one to migrate remaining (private) methods from Onyx.js file |
Typescript migration (react-native-onyx)
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
lib/Onyx.js
lib/index.js
The text was updated successfully, but these errors were encountered: