Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown characters are too faint on the live preview #36198

Closed
bfitzexpensify opened this issue Feb 9, 2024 · 7 comments
Closed

Markdown characters are too faint on the live preview #36198

bfitzexpensify opened this issue Feb 9, 2024 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@bfitzexpensify
Copy link
Contributor

bfitzexpensify commented Feb 9, 2024

Context https://expensify.slack.com/archives/C03U7DCU4/p1707425947365449

Examples:
image
image

Problem

Markdown characters are too faint on the live preview

Solution

Change the color, maybe to our supporting text like so:
image

@bfitzexpensify bfitzexpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

@bfitzexpensify
Copy link
Contributor Author

@tomekzaw please comment here so I can assign this issue to you - thanks!

@tomekzaw
Copy link
Contributor

tomekzaw commented Feb 9, 2024

commenting, can't access the assets in issue description though

@thienlnam
Copy link
Contributor

Updated the image assets

@tomekzaw
Copy link
Contributor

tomekzaw commented Feb 9, 2024

Thanks, now I see it, I agree that Markdown syntax characters are too faint indeed.

Currently, we're using colors.productLight600 / colors.productDark600 (see here, here and here).

Sounds like an easy fix, will submit a PR with more visible colors.

@tomekzaw
Copy link
Contributor

Should be fixed with #36320

@thienlnam
Copy link
Contributor

Should be live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants