[$500][MEDIUM] Bank account - Fields are empty after navigating back to add BA modal

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Pre-requisite: the user must be logged in and have created a workspace.

1. Go to Workspace > Bank account.
2. Select "Connect manually".
3. Enter the routing number and account number.
4. Tap on the back arrow.
5. Navigate back to the Add bank account modal > Manual option.

Expected Result:

The data entered before should remain on the fields.

Actual Result:

The fields are empty.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378775_1707868433137.Bmzd4213_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016f94e09a4ab6f001
• Upwork Job ID: 1757555443937619968
• Last Price Increase: 2024-02-14

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016f94e09a4ab6f001

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[mountiny]

I dont think this is a blocker, we should investigate the root cause however, @barttom @shubham1206agra @MrMuzyk

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are clearing the first screens bank info on initial load

What is the root cause of that problem?

We starting doing this since: bf43cc4
The code specifically instructs to clear the bank page screen on initial load.
because of: #31121 (comment)

They wanted it to reset to prevent this scenario and being stuck.

What changes do you think we should make in order to solve the problem?

I think we should remove the removeExistingBankAccountDetails logic.
After reviewing the issue, it seems like an edge case that the user is able to recover from.

What alternative solutions did you explore? (Optional)

[jeremy-croff]

We can handle that edge case in a seperate ticket if desired, to reset if the user is in that step and the information is not passing validation.

[mountiny]

Thanks I agree this is an edge case for now.

[akinwale]

@jeremy-croff Your proposed solution does not fix the core issue here which is that the data is not being saved after manually entering text in the input fields.

[shubham1206agra]

@mountiny Should we consider this a bug at all? I am more inclined to do nothing here.

[jeremy-croff]

@jeremy-croff Your proposed solution does not fix the core issue here which is that the data is not being saved after manually entering text in the input fields.

I see my mistake now!
however it does address this flow:

2024-02-14_00-42-23.mp4

[jeremy-croff]

Rechecked, and confirmed that in conjuction with the previous line - we also have to remove

App/src/pages/ReimbursementAccount/BankInfo/BankInfo.tsx

Line 117 in 023d62c

ReimbursementAccountUtils.updateReimbursementAccountDraft(bankAccountData);

line for OP

[MrMuzyk]

I believe this is intended behaviour.

@nkuoch Can you confirm that?

[mountiny]

Checked again and I agree, we saving these values only once submitted so this would be a feature request more than a bug now