[$500] [HOLD #33932] Workspace - The contact disappears but red dot shown next to "Members"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.42-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4318764
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap settings
3. Tap Workspaces --- Workspace
4. Tap members
5. Tap invite members
6. Enter VOIP number +18183305290
7. Select & invite the contact to workspace
8. Note, there was a problem adding this workspace member shown
9. Note contact number and error disappear after an second
10. Tap app back button

Expected Result:

Using Voip number invited contact to WS, the contact disappears, so red dot must not be shown near members

Actual Result:

Using Voip number invited contact to WS, the contact disappears but red dot shown near members

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6384534_1708354668375.em.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b2eeb30b47a86301
• Upwork Job ID: 1767932995867865088
• Last Price Increase: 2024-03-13

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[lanitochka17]

@bz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Using Voip number invited contact to WS, the contact disappears but red dot shown near members

What is the root cause of that problem?

We clear the optimistic personal detail data of the invited user in failureData.

App/src/libs/actions/Policy.ts

Line 707 in 1806422

...newPersonalDetailsOnyxData.finallyData,

App/src/libs/PersonalDetailsUtils.ts

Line 120 in 1806422

personalDetailsCleanup[accountID] = null;

So when we invite some invalid users, these users disappear from the member page but policyMembers still stores this in failure data as an error member. And then the red dot still appears on the member section

App/src/libs/actions/Policy.ts

Lines 655 to 659 in 1806422

	const failureMembersState: OnyxCollection<PolicyMember> = {};
	accountIDs.forEach((accountID) => {
	optimisticMembersState[accountID] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD};
	failureMembersState[accountID] = {
	errors: ErrorUtils.getMicroSecondOnyxError('workspace.people.error.genericAdd'),

What changes do you think we should make in order to solve the problem?

We shouldn't clear the personal detail data of the invited users in failureData by removing this line. With this, the invalid member can be displayed with an error. That's helpful for the user to know why we cannot invite this user and when we clear all errors, the red dot in the member section will disappear automatically

App/src/libs/actions/Policy.ts

Line 707 in 1806422

...newPersonalDetailsOnyxData.finallyData,

What alternative solutions did you explore? (Optional)

We can remove the invited user from policyMembers in failureData

App/src/libs/actions/Policy.ts

Lines 655 to 659 in 1806422

	const failureMembersState: OnyxCollection<PolicyMember> = {};
	accountIDs.forEach((accountID) => {
	optimisticMembersState[accountID] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD};
	failureMembersState[accountID] = {
	errors: ErrorUtils.getMicroSecondOnyxError('workspace.people.error.genericAdd'),

Result

Screen.Recording.2024-02-20.at.10.36.09.mov

[mallenexpensify]

@slafortune put on hold pending

• [LOW] [Groups] [$500] Room - Inconsistency in behaviour while adding VOIP number as contact via start chat&room #33932

Bumped to weekly

[slafortune]

Not overdue, on Hold

[dukenv0307]

@slafortune The issue #33932 is complete, I think we can off hold now and we can update the test step with another phone number like +18183305290 since now we accept to invite VOIP number.

[slafortune]

I updated the test with the new number and was able to still recreate this issue. Adding the external tag

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b2eeb30b47a86301

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[bernhardoj]

This is already being handled in #37895

[slafortune]

Thanks @bernhardoj - I'll close this 👍