[HOLD for payment 2024-06-05] [Violations - Pending Receipts] Add "Mark as cash" Button to MoneyRequestStatusBar

[yuwenmemon]

Design Doc: https://docs.google.com/document/d/1zJqlTe_RajuBtfQYvbMx8PpXgA9CEnUGVyuqZihQ-ok/edit
Tracking GH: https://github.com/Expensify/Expensify/issues/372206

HOLD ON https://github.com/Expensify/Expensify/issues/385017

---

We'll add support for a button and corresponding callback in the MoneyRequestHeaderStatusBar. This will allow us to support the "Mark as cash" button shown below.

In the case of the isPendingReceiptMatch status, the button will only be shown to the submitter of the expense. The callback function for the button will call a new API command: MarkAsCash. This will be through a Transaction action function of the same name (more on this below). The command will use the DismissViolation Auth command added recently.

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[JmillsExpensify]

Still on hold.

[smelaa]

Hi, I am Aleksandra Smela from Software Mansion, an expert agency, and I would like to work on this issue.

[grgia]

Not overdue, in progress

[BrtqKr]

Two small questions:

• what is a isPendingReceiptMatch status?
• by submitter of the expense you mean isActionOwner?

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[grgia]

@dubielzyk-expensify mind confirming the web design for the Mark as cash button?

cc @smelaa

[grgia]

what is a isPendingReceiptMatch status?

@BrtqKr seems isPendingReceiptMatch has been replaced with hasPendingRTERViolation

by submitter of the expense you mean isActionOwner?

Yes, that sounds correct

[dubielzyk-expensify]

@dubielzyk-expensify mind confirming the web design for the Mark as cash button?

Sorry, but I'm a bit unsure what you mean here 😅 Do you mean the desktop design or just confirming what mock should be used?

[grgia]

The Desktop design @dubielzyk-expensify

[grgia]

same as above

[JmillsExpensify]

Still working through the draft PR

[JmillsExpensify]

PR hit staging, so we're just waiting for the next production deploy.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add markAsCash button with wired up action for dismissing the rter violation #41835

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)
• @smelaa does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)
• Contributor: @smelaa is from an agency-contributor and not due payment

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

@c3024 Mind suggesting regression steps since this is a new feature?

[JmillsExpensify]

Payment summary:

• @c3024 $250

[c3024]

The tests have steps like fetching transaction id of a transaction and changing Onyx values from browser console. I am not sure if this will be a useful regression test.

Regression Test Proposal

1. Go to any open report - a workspace for example
2. Submit an expense and retrieve its transactionId transaction_id
3. Go to the report screen of this expense and in the console, input the following and press Enter

Onyx.merge('cardList', {
        1: {
            bank: 'Expensify Card',
            lastFourPAN: 3458,
        },
    });

Onyx.merge(`transactions_<transaction_id>`, {cardID: 1, merchant: 'violation test'});

Onyx.merge(`transactionViolations_<transaction_id>`, [{type: 'test', name: 'rter', data: {pendingPattern: true}}]);

4. Verify that Mark as cash button appears at the header
5. Press the Mark as cash button
6. Verify that the violation message disappears and there is a system message marked as cash added on the report screen.

[JmillsExpensify]

Thank you! What's your Upwork profile so that I can send you an offer.

[JmillsExpensify]

I'll slightly modify the regression steps, specifically 3, as QA has cards to test with.

[c3024]

Here, it is
https://www.upwork.com/freelancers/~0105555e2f227dbf47

Thanks!

[JmillsExpensify]

Upwork contract paid and regression test created!