[Pay 4/29][$250] [Track Tax] Error on Amount and Merchant field after changing tax rate when scanning is ongoing

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has several tax rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a scan request and include a tax rate.
4. When scanning is in progress, go to transaction thread.
5. Click Tax rate and change to a different tax rate.

Expected Result:

No error on Amount and Merchant field will show up after changing the tax rate.

Actual Result:

Error on Amount and Merchant field shows up briefly after changing the tax rate when scnaning is ongoing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438765_1712290267104.20240405_120557.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011d90b50207f85d2f
• Upwork Job ID: 1777350902764363776
• Last Price Increase: 2024-04-08
• Automatic offers:
• cubuspl42 | Reviewer | 0
• tienifr | Contributor | 0

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[MonilBhavsar]

This is not a deploy blocker, as only error appears momentarily and not breaking anything. I'm taking a look if it is a quick fix...

[MonilBhavsar]

Okay, it was confirmed here and this is not an issue specific to tax as it also appears with other field, so this can be made external https://expensify.slack.com/archives/C03UK30EA1Z/p1712339248417789?thread_ts=1700633473.392829&cid=C03UK30EA1Z

I am also unassigning myself

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011d90b50207f85d2f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[mallenexpensify]

Sorry, didn't realize the PR hit production yesterday,

[melvin-bot]

@cubuspl42, @lakchote, @adelekennedy, @tienifr Eep! 4 days overdue now. Issues have feelings too...

[adelekennedy]

@mallenexpensify confirming you've already taken care of @cubuspl42 payment in the linked issue above?

[adelekennedy]

Payouts due:

• Contributor: $250 @tienifr (Upwork)
• C+: $250 @cubuspl42 (Upwork)

Upwork job is here.

[mallenexpensify]

@adelekennedy , thanks for double checking. This was an edge case (and/or a mistake on my part), I've paid @cubuspl42 for this outside of this issue. I checked to box above,

@lakchote , @adelekennedy @tienifr do we want a regression test for this?

[melvin-bot]

@lakchote @adelekennedy @tienifr this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[lakchote]

@lakchote , @adelekennedy @tienifr do we want a regression test for this?

I think a regression test can't hurt to prevent this from happening in the future and ensuring a smooth user experience.

[adelekennedy]

Then to close this out @tienifr will you suggest a regression test and I can create an issue for it?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[adelekennedy]

bump @tienifr for the test steps!