[HOLD for payment 2024-06-06] [$250] Loading indicator is not shown when loading newer messages

[janicduplessis]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @janicduplessis
Slack conversation:

Action Performed:

Using comment linking, scroll down to load newer messages.

Steps to use comment linking:

1. Go in a long chat and scroll to an old message
2. Right click and "Copy link"
3. Go in another chat and paste the link
4. Clear the cache (Account Settings -> Troubleshoot -> Clear cache and restart)
5. Go back to the chat with the link and click it

Expected Result:

A loading indicator is displayed when loading newer messages.

Actual Result:

A loading indicator is not displayed when loading newer messages.

Workaround:

No workaround needed, messages still load fine.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-05-16.at.23.59.11.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cdefce63e38aaf4f
• Upwork Job ID: 1792627420945985536
• Last Price Increase: 2024-05-20
• Automatic offers:
• jayeshmangwani | Reviewer | 0

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cdefce63e38aaf4f

[melvin-bot]

Current assignee @jayeshmangwani is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@janicduplessis, @sonialiap, @jayeshmangwani, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

A second Pr got merged so this will be ready for payment soon

[sonialiap]

Is this the second PR? #42332 if counting from it's deploy date then payment will be due on June 5

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix canShowHeader logic #42332

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @janicduplessis does not require payment (Contractor)
• @jayeshmangwani requires payment automatic offer (Reviewer)
• @janicduplessis does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

All looks good

Payment summary:

• @jayeshmangwani reviewer $250 - please request in ND

[jayeshmangwani]

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking #30269
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 4f4a2c2#r142801008
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to any long chat and scroll to an older messages
2. Right click and "Copy link"
3. Go in another chat and paste the link
4. Clear the cache (Account Settings -> Troubleshoot -> Clear cache and restart)
5. Go back to the chat with the link and click it
6. Verify that when loading newer messages loading indicator is displayed

Do we agree 👍 or 👎

[jayeshmangwani]

reviewer $250 - offer is pending, please accept

@sonialiap Is that possible to get payment through ND for this issue as now I am getting paid through it and withdraw Upwork offer ? If not then no issues I can accept the Upwork offer.

[sonialiap]

Definitely! I'll withdraw the upwork offer and update the payment summary

[JmillsExpensify]

$250 approved for @jayeshmangwani