[HOLD for payment 2024-06-13] User profile - App shows Hidden profile instead of not here page when profile link is invalid

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #42464
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Send a link of an invalid profile (https://staging.new.expensify.com/a/hellodsdsdsdsdsd
   ).
4. Click on the link.

Expected Result:

App will show not here page.

Actual Result:

App shows profile of a Hidden user.
When clicking on Message Hidden, the report shows error.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6494994_1716979769510.invalid_user.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

bandicam.2024-05-29.14-29-34-189.mp4

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User profile - App shows Hidden profile instead of not here page when profile link is invalid

What is the root cause of that problem?

The problem is that #41846 changed to a condition to check if the accountID is present or if the user details are not found.

App/src/pages/ProfilePage.tsx

Lines 141 to 142 in 6726431

	<ScreenWrapper testID={ProfilePage.displayName}>
	<FullPageNotFoundView shouldShow={CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID)}>

Therefore, the ValidationUtils.isValidAccountRoute function marks the accountID as invalid even if the accountID is NaN because the route.params?.accountID is hellodsdsdsdsdsd which becomes NaN.

https://github.com/Tony-MK/Expensify-App/blob/79ae8a17ec5d6b104f4b46c5f10992797e41c121/src/pages/ProfilePage.tsx#L93

What changes do you think we should make in order to solve the problem?

We need to check if the user is not found by checking if the user account is not Nan for the route.params?.accountID and for the ValidationUtils.isValidAccountRoute function.

[Kicu]

hey I did the PR that broke this, but I was originally tried to fix this problem: #40989 which was exactly the reverse - that in offline mode we showed not found page.

However I see the underlying problem - in offline mode, when api is not available how can the App tell whether an email is valid or not?
This simple solution suggested above by @Tony-MK, that is adding !isEmptyObject(details.avatar) to the check will bring back this bug: #40989

I'm happy to provide a fix but Im not sure what behavior we want re: invalid profile/profile in offline mode?

[Tony-MK]

@Kicu, After rechecking the problem, it has to do with the accountID becoming Nan because route.params?.accountID is not a number but string.

[Kicu]

oh thanks for extra info 👍
But that seems weird that accountID is a string. Usually ids of workspaces/policies are strings, whereas if it's a user the id was always a number. The line responsible for parsing (in ProfilePage):

    const accountID = Number(route.params?.accountID ?? 0);

is not something I added - that was already there.

I will be monitoring this task if any further changes are needed but at this moment I'm unsure what I could fix/change.

[mountiny]

I will take this over as i am reviewer on that pr

[joekaufmanexpensify]

Thanks Vit!

[Tony-MK]

Hey @Kicu, the line below makes details = {accountID: 0},

const details: PersonalDetails | EmptyObject = personalDetails?.[accountID] ?? (ValidationUtils.isValidAccountRoute(accountID) ? {} : {accountID: 0});

So, this new condition should work.

<FullPageNotFoundView 
  shouldShow={details.accountID === 0 || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID)}
>

[Kicu]

Okey great suggestion, thanks.
I will test this locally, do you want me to provide the PR @mountiny ?

[joekaufmanexpensify]

@Kicu yeah if you could raise a PR that would be great. Is there an ETA for when you could have one up?

[Tony-MK]

Since I am pretty free, could I raise the PR?

Thanks

[joekaufmanexpensify]

@Tony-MK generally we try have the same person who introduced a deploy blocker fix it, if they're available. We appreciate your enthusiasm though!

[Kicu]

I will do it

[mountiny]

Thanks for the discussion, I think that this is very specific flow that user will not really get into.

And if they will, the App works fine, and does not crash or anything so I think @Kicu @s77rt should fix this as the authors of the original PR with urgency, but I will remove the deploy blocker label

[Kicu]

PR with fix is here: #42769

I hope there is no more edge cases for this view that I missed, but what I did should be equivalent to the code that was handling this previously

[joekaufmanexpensify]

PR awaiting deploy

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix normal Profile Page displayed for invalid accountID #42769

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[joekaufmanexpensify]

This was fixing a deploy blocker introduced from another PR that @Kicu and @s77rt worked on, so no payment is due here.

[joekaufmanexpensify]

Closing as this is on production, thanks everyone!