[Hold] RTER Pending Expense - RTER Pending expense is not moved to new report when it's approved

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.20-6

Reproducible in staging?: Yes
Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/403524#issuecomment-2290080995

Email or phone of affected tester (no customers): [email protected]

Logs: https://stackoverflow.com/c/expensify/questions/4856

Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

Preconditions: a workspace with scheduled submit enabled, a employee and admin and the employee has a company card assigned.

1. In an account that has a domain controlled company card (not Expensify Card)
2. Submit a expense via scan in the workspace chat
3. Wait for the smartscan to finish
4. Verify the expense has pending status
5. In the workspace chat, submit a manual expense
6. Submit the report
7. As the approver - Approve the report

Expected Result:

The pending expense should be moved to a new Report.

Actual Result:

The pending expense is not moved to a new report and it still has the Pending Status.

Below are the details of a report with this issue:
Account: [email protected]
Report ID: 8189390567239041
Transaction ID: 6273679857286185

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

Going to drop off this one, Gents. I'm sure you know what you're doing :)

[melvin-bot]

@JmillsExpensify, @yuwenmemon Whoops! This issue is 2 days overdue. Let's get this updated quick!

[yuwenmemon]

Looking today

[JmillsExpensify]

This is coming up with customers btw. More in Slack.

[yuwenmemon]

After some further discussion in Slack we were conflating this with the other Pending CC Transaction state, which is affecting the customer.

This one might actually benefit from waiting a bit while we get the RTER Violation in Auth (cc @deetergp), since we would be able to keep all logic there and have it be 1:1:1.

[yuwenmemon]

Waiting on https://github.com/Expensify/Auth/pull/11972 before implementing this in Auth

[yuwenmemon]

Still waiting on https://github.com/Expensify/Auth/pull/11972

[yuwenmemon]

Still on HOLD

[melvin-bot]

@JmillsExpensify, @yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

[garrettmknight]

Just adding the issue that this is held on for reference: https://github.com/Expensify/Expensify/issues/393838

[JmillsExpensify]

Still holding

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @yuwenmemon eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[yuwenmemon]

Un-holding as violations in Auth are done now.

[JmillsExpensify]

Nice, thank you!

[yuwenmemon]

I took a look at this today, and some questions came up. I'm asking @pecanoro for her advice on how to proceed best with getting violations in Auth for use within Auth.

[yuwenmemon]

Okay so we're still holding on this just a touch. Rocio let me know that we can't use Violations::get yet on production code as it's still not accurate with its PHP version. We fixing the diff here: https://github.com/Expensify/Expensify/issues/457686

[yuwenmemon]

Looks like the issue above is in Review so we're close!

[yuwenmemon]

Talked with @pecanoro IRL during onshore and it looks like there are some still issues with the RTER violation diff - so still in a holding pattern on this one for now.

[JmillsExpensify]

Added the hold

[JmillsExpensify]

Still on hold