[Due for payment 2025-02-18] [$250] [Search v2.2] Add room name to the top of chats #48897

luacmartins · 2024-09-10T14:43:57Z

Problem

Coming from here, chats miss the context of the room they belong too, so users can find the same chat sent to different people.

Solution

Add the room name to the chats. This requires both backend and frontend changes.

Issue Owner

Current Issue Owner: @stephanieelliott

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021834524447256118011
Upwork Job ID: 1834524447256118011
Last Price Increase: 2024-09-13
Automatic offers:

situchan | Reviewer | 103992205
DylanDylann | Contributor | 104770986

melvin-bot · 2024-09-10T14:44:06Z

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot · 2024-09-13T09:28:08Z

Job added to Upwork: https://www.upwork.com/jobs/~021834524447256118011

melvin-bot · 2024-09-13T09:28:14Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

luacmartins · 2024-09-13T13:50:23Z

cc @Kicu @289Adam289 @SzymczakJ @Guccio163 in case you wanna work on the frontend part of this. These changes also have a backend component that's still not available.

zfurtak · 2024-09-16T11:20:05Z

hello @luacmartins I would like to take care of this issue. When do you expect the backend changes to be ready? 🤔

melvin-bot · 2024-09-16T18:24:16Z

@luacmartins, @stephanieelliott, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2024-09-16T21:49:54Z

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

luacmartins · 2024-09-16T21:49:54Z

All yours @zfurtak

zfurtak · 2024-09-17T09:31:58Z

Do you have any idea when the backend will be ready @luacmartins? 😃

luacmartins · 2024-09-18T01:12:58Z

@zfurtak I started looking into this today. I have a draft PR to return report data in the chat queries, but I'm not sure that that's enough to display the correct report names. Do you know which data you'll need to properly display them? It seems like we need quite a bit of data for getReportName

luacmartins · 2024-09-18T01:17:14Z

Here's a sample data after we start returning the report data:

[
    {
        "key": "snapshot_2089317297",
        "onyxMethod": "set",
        "value": {
            "data": {
                "personalDetailsList": {
                    "844": {
                        "accountID": 844,
                        "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_5.png",
                        "displayName": "sdf",
                        "firstName": "sdf",
                        "lastName": "",
                        "login": "[email protected]"
                    }
                },
                "reportActions_2226999844364749": {
                    "6133238980486036910": {
                        "accountID": 844,
                        "actionName": "ADDCOMMENT",
                        "created": "2024-08-27 21:00:44.078",
                        "message": [
                            {
                                "html": "<a href=\"https://dev.new.expensify.com:8082/search?q=type%3Achat%20status%3Alinks%20sortBy%3Adate%20sortOrder%3Adesc&amp;isCustomQuery=false\" target=\"_blank\" rel=\"noreferrer noopener\">https://dev.new.expensify.com:8082/search?q=type%3Achat%20status%3Alinks%20sortBy%3Adate%20sortOrder%3Adesc&amp;isCustomQuery=false</a>",
                                "text": "https://dev.new.expensify.com:8082/search?q=type%3Achat%20status%3Alinks%20sortBy%3Adate%20sortOrder%3Adesc&isCustomQuery=false",
                                "type": "COMMENT",
                                "whisperedTo": []
                            }
                        ],
                        "reportActionID": "6133238980486036910",
                        "reportID": "2226999844364749"
                    }
                },
                "reportActions_3613091925157067": {
                    "4865297248518576461": {
                        "accountID": 844,
                        "actionName": "ADDCOMMENT",
                        "created": "2024-09-12 22:55:20.809",
                        "message": [
                            {
                                "html": "<a href=\"https://www.expensify.com.dev/chat-attachments/4865297248518576461/w_efeb24490b01fb7b9b2c596b6cafafd778c09e3e.sh\" data-expensify-source=\"https://www.expensify.com.dev/chat-attachments/4865297248518576461/w_efeb24490b01fb7b9b2c596b6cafafd778c09e3e.sh\">checkDeploymentSuccess.sh</a>",
                                "text": "[Attachment]",
                                "type": "COMMENT",
                                "whisperedTo": []
                            }
                        ],
                        "reportActionID": "4865297248518576461",
                        "reportID": "3613091925157067"
                    }
                },
                "report_2226999844364749": {
                    "accountID": 0,
                    "action": "view",
                    "created": "2024-03-27 17:09:53",
                    "currency": "USD",
                    "managerID": 0,
                    "policyID": "818714A5DBC2E598",
                    "reportID": "2226999844364749",
                    "reportName": "#admins",
                    "total": 0,
                    "type": "chat"
                },
                "report_3613091925157067": {
                    "accountID": 0,
                    "action": "view",
                    "created": "2024-02-20 18:23:08",
                    "currency": "USD",
                    "managerID": 0,
                    "policyID": "_FAKE_",
                    "reportID": "3613091925157067",
                    "reportName": "Chat Report",
                    "total": 0,
                    "type": "chat"
                }
            },
            "search": {
                "columnsToShow": {
                    "shouldShowCategoryColumn": true,
                    "shouldShowTagColumn": true,
                    "shouldShowTaxColumn": true
                },
                "hasMoreResults": false,
                "offset": 0,
                "status": "links",
                "statusToShow": {
                    "expense": {
                        "all": true,
                        "approved": false,
                        "drafts": true,
                        "outstanding": true,
                        "paid": true
                    }
                },
                "type": "chat"
            }
        }
    }
]

melvin-bot · 2025-02-07T03:23:35Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.