Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expensify Card - Member cannot see card details from link in workspace chat unless Wallet is opened #50471

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 8, 2024 · 14 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.46-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. [Admin] Asssign a virtual card to member
  3. [Member] Do not go to Wallet page (important)
  4. [Member] Go to workspace chat
  5. [Member] Click on Expensify Card link
  6. [Member] Note that Expensify Card details are not revealed (limit and buttons) when opened from the link
  7. [Member] Go to Wallet
  8. [Member] Go back to workspace chat and open Expensify Card link
  9. [Member] Note that Expensify Card details are only revealed (limit and buttons) after user opens Wallet page

Expected Result:

In Step 6, member should be able to see their Expensify Card details (limit and buttons) without going to Wallet page

Actual Result:

In Step 6, member is not able to see their Expensify Card details. It does not show the limit and buttons are hidden
In Step 9, after opening Wallet page, user can see Expensify Card details from the link in workspace chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6628452_1728400120105.20241008_230120.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@allgandalf
Copy link
Contributor

@truph01 @jjcoffee related to your PR ? #50039

@truph01
Copy link
Contributor

truph01 commented Oct 8, 2024

@allgandalf I think it is bug 2 I mentioned here. BE should handle it by sending pusher data.

@allgandalf
Copy link
Contributor

@truph01 lets talk in this slack thread

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 8, 2024
@thienlnam
Copy link
Contributor

Not a blocker from slack thread since this is not a common flow in NewDot, though should be fixed soon

@truph01
Copy link
Contributor

truph01 commented Oct 8, 2024

@thienlnam This should be fixed in BE, right?

@thienlnam thienlnam added the Internal Requires API changes or must be handled by Expensify staff label Oct 8, 2024
@thienlnam
Copy link
Contributor

Yeah, looks like it can be - cc @mountiny for how to proceed on this

@mountiny mountiny assigned mountiny and unassigned pecanoro Oct 8, 2024
@mountiny
Copy link
Contributor

mountiny commented Oct 8, 2024

Gonna take over

@mountiny
Copy link
Contributor

I think this is already sorted as we started to push the onyx updates about new virtual cards correctly now

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2024
@mountiny
Copy link
Contributor

@izarutskaya
Copy link

Issue is not reproducible anymore.

bandicam.2024-10-14.20-15-12-937.mp4

@mountiny
Copy link
Contributor

Perfect so that was fixed with the auth pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants