Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Android app – Copilot – Unable to switch to own account from copilot account #51042

Closed
1 of 8 tasks
IuliiaHerets opened this issue Oct 17, 2024 · 58 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.50-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5097100
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to Hybrid app
  2. Login as the account that has full copilot access
  3. Tap on Settings/header arrows
  4. Switch to copilot accounts
  5. Tap on Settings/header arrows again
  6. Switch to your own accounts

Expected Result:

User able to switch to own account from copilot account

Actual Result:

Error appears: Oops something went wrong

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6637677_1729169752290.video_2024-10-17_15-55-31.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @dangrous
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Oct 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 17, 2024

💬 A slack conversation has been started in #expensify-open-source

@IuliiaHerets IuliiaHerets added DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment and removed DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 17, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Sorry, was confused with blocker label

@jasperhuangg jasperhuangg added the DeployBlocker Indicates it should block deploying the API label Oct 17, 2024
@jasperhuangg
Copy link
Contributor

@IuliiaHerets next time add both labels, they're used to indicate that the bug could either be from the front-end or the back-end.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Oct 17, 2024

These logs seem suspect, I'll try to reproduce on my own account to see if I run into the same issue. Need to wait for the beta cache to refresh though.

The logs indicate that the authPartnerID stored with the restored token we're passing to the CreateLogin command isn't recognized.

@twisterdotcom
Copy link
Contributor

Nobody needs paying here right?

@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-12-19] Hybrid Android app – Copilot – Unable to switch to own account from copilot account Hybrid Android app – Copilot – Unable to switch to own account from copilot account Dec 19, 2024
@dangrous
Copy link
Contributor

I think @mollfpr will need payment for C+ review.

But I still need to double check that this is working on prod; @war-in suggests that it might not be yet. I'm about to try locally and on browserstack

@dangrous
Copy link
Contributor

Okay so this doesn't work for me on hybrid app (though it works on regular android app). I don't know what changed!

@war-in
Copy link
Contributor

war-in commented Dec 20, 2024

I'm gonna build the app from the main branches and try to find some logs. I'll post them here 🫡

@war-in
Copy link
Contributor

war-in commented Dec 20, 2024

I managed to make it work by merging the main branches (not sure what exactly changed but it works 🤷).
Now I have a question about those few set actions

A few lines above we update the authToken and encryptedAuthToken but immediately we override them by calling the set with old (stashed) data.
I think we should update tokens after calling set. Do you think it makes sense?

@dangrous
Copy link
Contributor

oh huh, yeah I think you're right!

@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

@dangrous, @twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 26, 2024

@dangrous, @twisterdotcom Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 30, 2024

@dangrous, @twisterdotcom Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Jan 1, 2025

@dangrous, @twisterdotcom 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Jan 3, 2025

@dangrous, @twisterdotcom 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

This issue has not been updated in over 14 days. @dangrous, @twisterdotcom eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@dangrous
Copy link
Contributor

dangrous commented Jan 9, 2025

Hi Melvin, still in progress. Aiming for early next week

@garrettmknight garrettmknight added the Internal Requires API changes or must be handled by Expensify staff label Jan 14, 2025
@dangrous
Copy link
Contributor

Estimated merge is on Friday!

@dangrous
Copy link
Contributor

50% there - ND PR is merged, and the Mobile-Expensify one is up for final review from SWM

@dangrous
Copy link
Contributor

okay! both PRs are merged. Not quite deployed. Once we're there, I think we can just test and close!

@dangrous
Copy link
Contributor

@dangrous
Copy link
Contributor

Oh wait maybe we don't get comments on deploys in M-E? Checking in Slack, but hopefully that means we can get this re-tested and closed!

@Julesssss
Copy link
Contributor

Yeah, there's no staging branch or deploy on Mobile-E. Once merged to main the next App build (including CP builds) will include the mobile changes.

@dangrous
Copy link
Contributor

ah great! @IuliiaHerets are you able to retest this?

@IuliiaHerets
Copy link
Author

@dangrous Issue is not reproduced now

screen-20250131-070911.mp4

@dangrous
Copy link
Contributor

Amazing! I think we can close this - I don't believe any payment is required. If someone disagrees, ping here!

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

9 participants