Skin tone selector does not have the same dimensions as the emoji list

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to a conversation
2. Open emoji picker
3. Click on the skin color selector

Expected Result:

Skin selector emojis should have the same dimensions and design as the rest of the emoji list.

Actual Result:

Skin selector emojis have a different height and don't have rounded edges as the rest of the emojis.

Workaround:

No need, visual issue.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.98-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1631558477208900

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @michelle-thompson (Design), see these Stack Overflow questions for more details.

[MelvinBot]

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

It should be marked as a deploy blocker as the new skin tone selector has issues.
The second part where some emojis have different dimensions is a side-effect and should be marked as regression.
Platform

1. Web - (Firefox > 81)

[isagoico]

This issue is already in production so I don't think it should be marked as deploy blocker. It was added here #4456

[parasharrajat]

Thanks for pointing out the PR causing the Regression @isagoico. #4456. @mananjadhav Could you please take a look and confirm?

[mananjadhav]

Thanks for posting this. Yeah, it's a part of PR #4456. It didn't come across in the review and the testing that we'll need them to be of the same size.

I'll check and fix this.

[kadiealexander]

Hi @mananjadhav, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

[parasharrajat]

Its a regression @kadiealexander I don't think there will be a job for this.

[mananjadhav]

I am not sure if we would count it as regression. This PR was under review for over a month and this never came up. @stitesExpensify can comment on this

[kadiealexander]

Will leave this for @stitesExpensify to decide :)

[mananjadhav]

Thanks. Just to add, I am not expecting a separate Job posting for this one :)

[stitesExpensify]

I wouldn't consider it a regression because it never worked in the first place. I'd say this is more of an easy bug fix that should have a small job

[MelvinBot]

@mananjadhav Eep! 4 days overdue now. Issues have feelings too...

[mananjadhav]

PR under review

[MelvinBot]

@mananjadhav Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@mananjadhav Still overdue 6 days?! Let's take care of this!

[mananjadhav]

PR under review and n6-hold

[MelvinBot]

@mananjadhav Huh... This is 4 days overdue. Who can take care of this?

[parasharrajat]

@kadiealexander Am I eligible for issue reporting bonus here?

[stitesExpensify]

IMO that makes sense. You're tagged as the person who flagged it in the OP

[kadiealexander]

Added a bonus to the Upwork Post for this issue: #5422 to avoid creating extra jobs. Thanks Rajat!

[kadiealexander]

Also whipped up a job post to get @mananjadhav paid for the work done here, thanks Manan! I've invited you, please let me know when you've applied and I'll hire you, and pay out the job + bonus for the wait because of the n6-hold. https://www.upwork.com/jobs/~0199560da6fbed0b19

[MelvinBot]

@mananjadhav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

@mananjadhav 10 days overdue. I'm getting more depressed than Marvin.

[mananjadhav]

PR is deployed to production

[MelvinBot]

@mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mananjadhav]

@kadiealexander Can you please help with this? PR is merged and into production 8 days back.

[kadiealexander]

Released payment, no bonus as this was not held for n6. :)

Edit: Spoke to Manan and as this was supposed to be held for n6 and was on hold for a month before merging, I'll still pay out the bonus here.