Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-07] [$250] Dedupe multiple LogOut requests #53070

Closed
rinej opened this issue Nov 25, 2024 · 13 comments
Closed

[HOLD for payment 2024-12-07] [$250] Dedupe multiple LogOut requests #53070

rinej opened this issue Nov 25, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@rinej
Copy link
Contributor

rinej commented Nov 25, 2024

Problem

We are seeing some scenarios where multiple LogOut requests are serialized in a row. When multiple such requests are sent, it's redundant, as only one is relevant. It slows down the app, and contributes to server traffic.

Solution

Dedupe multiple LogOut requests

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021862137674835272041
  • Upwork Job ID: 1862137674835272041
  • Last Price Increase: 2024-11-28
  • Automatic offers:
    • rojiphil | Contributor | 105110958
Issue OwnerCurrent Issue Owner: @zanyrenney
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Nov 27, 2024
@rinej
Copy link
Contributor Author

rinej commented Nov 27, 2024

PR -> #53143

@mountiny mountiny moved this to CRITICAL in [#whatsnext] #quality Nov 27, 2024
@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 27, 2024
@rojiphil
Copy link
Contributor

@mountiny Please assign me to the issue as well. Thanks.

@mountiny
Copy link
Contributor

$250 to @rojiphil

@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021862137674835272041

@melvin-bot melvin-bot bot changed the title Dedupe multiple LogOut requests [$250] Dedupe multiple LogOut requests Nov 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Current assignee @rojiphil is eligible for the External assigner, not assigning anyone new.

@zanyrenney zanyrenney assigned rojiphil and unassigned rojiphil Nov 28, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@rojiphil
Copy link
Contributor

@zanyrenney I have accepted the offer. Thanks.

@zanyrenney
Copy link
Contributor

payment summary

paid @rojiphil $250 via Upwork.

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Nov 28, 2024
@zanyrenney
Copy link
Contributor

PR is merged so payment complete and now closing!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 30, 2024
@melvin-bot melvin-bot bot changed the title [$250] Dedupe multiple LogOut requests [HOLD for payment 2024-12-07] [$250] Dedupe multiple LogOut requests Nov 30, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 30, 2024

@rojiphil @zanyrenney @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants