Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #56812] iOS - Distance rates - Bottom tab appears on Settings when swiping from workspace settings #57075

Open
2 of 8 tasks
mitarachim opened this issue Feb 19, 2025 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.1.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #56870
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Workspace Settings

Action Performed:

  1. Launch ND or hybrid app.
  2. Create a new workspace.
  3. Go to workspace settings > More features.
  4. Enable Distance rates.
  5. Go to Distance rates.
  6. Tap Settings.
  7. Tap More features.
  8. Swipe to right to return to previous page.
  9. On workspace settings page, swipe to right slowly to go back to rate settings page.

Expected Result:

Bottom tab will not appear on rate settings page.

Actual Result:

Bottom tab appears briefly on rate settings when swiping from workspace settings.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6747478_1739942985822.ScreenRecording_02-19-2025_13-25-38_1.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 19, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Feb 19, 2025
@thienlnam
Copy link
Contributor

Not an internal blocker, and doesn't constitute as an app blocker either - seems like small a navigation delay bug

@thienlnam
Copy link
Contributor

thienlnam commented Feb 19, 2025

Likely related to this PR though #56870 - @WojtekBoman Are you able to take a look here and see what you think?

@WojtekBoman
Copy link
Contributor

Hey @thienlnam, I'll check it

@WojtekBoman
Copy link
Contributor

WojtekBoman commented Feb 19, 2025

I'm currently working on another issue and it seems to work well on my PR, after going back from the more features page we are navigated to the page with the link (distance rate settings) what causes that this issue doesn't appear. Here's the video

Screen.Recording.2025-02-19.at.21.05.17.mov

Let me know if this app behaviour is ok for you :)

@thienlnam thienlnam changed the title iOS - Distance rates - Bottom tab appears on Settings when swiping from workspace settings [HOLD #56812] iOS - Distance rates - Bottom tab appears on Settings when swiping from workspace settings Feb 21, 2025
@thienlnam
Copy link
Contributor

Nice, looks great! We'll just hold for that issue to be completed then

@melvin-bot melvin-bot bot added the Overdue label Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

@NicMendonca, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 26, 2025

@NicMendonca, @thienlnam Eep! 4 days overdue now. Issues have feelings too...

@NicMendonca
Copy link
Contributor

@thienlnam @WojtekBoman can we unhold here?

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants