Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-27] [Due for payment 2025-02-27] [$250] iOS - FAB - FAB is not responsive after opening any page from FAB and closing it #57081

Closed
2 of 8 tasks
mitarachim opened this issue Feb 19, 2025 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@mitarachim
Copy link

mitarachim commented Feb 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.1.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Launch ND or hybrid app.
  2. Tap FAB > Create expense > Manual.
  3. Enter amount > Next.
  4. Tap app back button twice.
  5. Tap FAB.

Expected Result:

FAB will open.

Actual Result:

FAB is not responsive.

The same issue also happens when opening chat from FAB.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6747419_1739936930715.ScreenRecording_02-19-2025_11-46-33_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892225781719957968
  • Upwork Job ID: 1892225781719957968
  • Last Price Increase: 2025-02-19
  • Automatic offers:
    • ZhenjaHorbach | Contributor | 106313802
Issue OwnerCurrent Issue Owner: @trjExpensify
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 19, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Gonals Gonals added the External Added to denote the issue can be worked on by a contributor label Feb 19, 2025
@melvin-bot melvin-bot bot changed the title iOS - FAB - FAB is not responsive after opening any page from FAB and closing it [$250] iOS - FAB - FAB is not responsive after opening any page from FAB and closing it Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021892225781719957968

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Feb 19, 2025
@trjExpensify
Copy link
Contributor

@ZhenjaHorbach is working on reproducing in thead: https://expensify.slack.com/archives/C01GTK53T8Q/p1739977216932559?thread_ts=1739955455.215549&cid=C01GTK53T8Q

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion. Bartosz is OOO so I'm looking into this blocker 👀

@trjExpensify
Copy link
Contributor

Dope, assigning you! :)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 19, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Hourly KSv2 labels Feb 19, 2025
@melvin-bot melvin-bot bot added the Weekly KSv2 label Feb 19, 2025
@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 19, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [$250] iOS - FAB - FAB is not responsive after opening any page from FAB and closing it [Due for payment 2025-02-27] [$250] iOS - FAB - FAB is not responsive after opening any page from FAB and closing it Feb 20, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @blazejkustra does not require payment (Contractor)
  • @c3024 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Feb 20, 2025

@c3024 @trjExpensify @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-27] [$250] iOS - FAB - FAB is not responsive after opening any page from FAB and closing it [Due for payment 2025-02-27] [Due for payment 2025-02-27] [$250] iOS - FAB - FAB is not responsive after opening any page from FAB and closing it Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @blazejkustra does not require payment (Contractor)
  • @c3024 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Feb 20, 2025

@c3024 @trjExpensify @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@c3024
Copy link
Contributor

c3024 commented Feb 21, 2025

No payment for me here!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Payment Summary

Upwork Job

  • Contributor: @blazejkustra is from an agency-contributor and not due payment
  • Reviewer: @c3024 owed $250 via NewDot

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1892225781719957968/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@trjExpensify
Copy link
Contributor

No payment for me here!

Ah cool, @ZhenjaHorbach you reviewed. Can you complete the checklist, please?

@trjExpensify trjExpensify assigned ZhenjaHorbach and unassigned c3024 Feb 28, 2025
Copy link

melvin-bot bot commented Feb 28, 2025

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@ZhenjaHorbach
Copy link
Contributor

No payment for me here!

Ah cool, @ZhenjaHorbach you reviewed. Can you complete the checklist, please?

Actually no payment for me here also 😅
Since this is a regression from a PR which I reviewed

So I think we can close it when I add a checklist !

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Feb 28, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

  1. Launch ND or hybrid app
  2. Tap FAB and open Create expense
  3. Tap app back button
  4. Try to tap FAB
  5. Verify that FAB will open

Do we agree 👍 or 👎

@trjExpensify
Copy link
Contributor

Actually no payment for me here also 😅
Since this is a regression from a PR which I reviewed

So I think we can close it when I add a checklist !

Ah okay cool, closing then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants