-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet - mweb - Continue CTA not visible in bank account success page #57586
Comments
Triggered auto assignment to @stephanieelliott ( |
Triggered auto assignment to @robertjchen ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Continue button not visible at all in add bank account success page What is the root cause of that problem?We're not wrapping Confirmation page here inside App/src/pages/AddPersonalBankAccountPage.tsx Lines 93 to 100 in 7bda731
What changes do you think we should make in order to solve the problem?Wrap Confirmation page inside App/src/pages/AddPersonalBankAccountPage.tsx Lines 93 to 100 in 7bda731
{shouldShowSuccess ? (
<ScrollView contentContainerStyle={styles.flexGrow1}>
<ConfirmationPage
heading={translate('addPersonalBankAccountPage.successTitle')}
description={translate('addPersonalBankAccountPage.successMessage')}
shouldShowButton
buttonText={translate('common.continue')}
containerStyle={styles.h100}
onButtonPress={() => exitFlow(true)}
/>
</ScrollView> What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.7-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5666568
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 16/iOS 18/Safari 18
App Component: User Settings
Action Performed:
Scenario 1:
Expected Result:
Continue button should be visible at the bottom in add bank account success page
Actual Result:
Continue button not visible at all in add bank account success page
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/6912f9a3-d0f5-4e23-8035-1b59d3571587
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: