Desktop - BA - Incorrect page opens in browser via link from 'Connect BA' page on Desktop

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.7-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5668110
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: MacOS 14.7.4 / Desktop App
App Component: Workspace Settings

Action Performed:

1. Open Desktop App
2. Login with Expensifail.account
3. Create Workspace or go to existing one
4. Go to Settings > WS > Workflow > Connect Bank account
5. Click on link: "Note: To connect with Chase, Wells Fargo, Capital One or Bank of America, please click here to complete this process in a browser."

Expected Result:

"Connect bank account" page opens in a new browser tab

Actual Result:

"Workspace > Overview" opens in a new browser tab instead of "Connect bank account"

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6757163_1740714015816.Desktop-BA-to-Web-Wrong-page.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mitarachim]

in Production 9.1.6-1 , we have issue infinite loading in bank account page

Desktop-to-Web-PROD.mp4

[MariaHCD]

This PR was meant to fix the infinite loading issue on the ReimbursementAccountPage: #56131

But seems like it isn't working 100% since the Workspace > Overview page is being opened instead of the bank account page.

cc: @bernhardoj @eVoloshchak

[MariaHCD]

Tested this on staging desktop and it seems to work as expected 🤔

Screen.Recording.2025-02-28.at.11.53.07.AM.mov

[mitarachim]

i can reproduce this issue in STG while default web browser Safari/chrome.
make sure we are not already login in Safari/chrome.

Screen.Recording.2025-02-28.at.4.08.58.PM.mp4

Screen.Recording.2025-02-28.at.4.10.41.PM.mp4

I also re-checking , we can reproduce while Use Staging Server is Off

Screen.Recording.2025-02-28.at.4.25.02.PM.mp4

[bernhardoj]

make sure we are not already login in Safari/chrome.

I can repro with this. The bank account page is opened, but then somehow gets closed. There must be some logic that closes the page, so this is a different issue.

[bernhardoj]

Found the issue. The bank account RHP is dismissed because shouldShowNotFoundPage is true for a moment because the policy data is not available yet.

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 401 to 413 in 5a8a260

	useEffect(() => {
	if (!shouldShowNotFoundPage && canAccessRoute) {
	return;
	}
	if (wasRendered.current) {
	return;
	}
	wasRendered.current = true;
	// We are dismissing any modals that are open when the NotFound view is shown
	Navigation.isNavigationReady().then(() => {
	Navigation.closeRHPFlow();
	});
	}, [canAccessRoute, shouldShowNotFoundPage]);

I remember seeing an issue that is caused by the above logic too. It can easily be reproduced by deep-link to any workspace RHP while logged out, and then log in.

[eVoloshchak]

This is a different issue, not caused by #56131, rather surfaced by it.

As @bernhardoj has correctly pointed out, it can be reproduced using a deep-link to any workspace RHP while logged out, and then logging in, without the Desktop app even

Screen.Recording.2025-03-01.at.03.30.52.mov