Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS -Workspace - Endless spinner when tapping save button when making changes in general settings in offline mode #6685

Closed
kavimuru opened this issue Dec 10, 2021 · 7 comments
Labels
Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Monthly KSv2 Not a priority

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Disable the internet connection on the device
  2. Verify you can navigate back to workspace editor
  3. Click on General Settings again
  4. Change the workspace currency and name again
  5. Save the changes

Expected Result:

Error message should display about offline

Actual Result:

The endless spinner is displayed when try to Save the changes when user offline.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.19-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5366588_IMG_4583

Bug5366588_RPReplay_Final1639097815.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru changed the title iOS -Workspace - Endless spinner when tapping save button after making changed in general settings in offline mode iOS -Workspace - Endless spinner when tapping save button when making changes in general settings in offline mode Dec 10, 2021
@MelvinBot
Copy link

@robertjchen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

@robertjchen Eep! 4 days overdue now. Issues have feelings too...

@robertjchen
Copy link
Contributor

Thanks for the report, this looks like a great opportunity for a contributor. Appreciate the help!

@MelvinBot MelvinBot removed the Overdue label Dec 16, 2021
@robertjchen robertjchen added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 16, 2021
@robertjchen robertjchen removed their assignment Dec 16, 2021
@parasharrajat
Copy link
Member

parasharrajat commented Dec 16, 2021

We should probably hold this as this comes under offline issues.
cc: @pecanoro

@MelvinBot
Copy link

Eep! 4 days overdue now. Issues have feelings too...

@MelvinBot
Copy link

@kavimuru, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

4 participants