Deploy Checklist: New Expensify 2021-12-15

[OSBotify]

Release Version: 1.1.21-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update splash screen logic #6478

  • QA
  • Accessibility

• Handle popover showing from side only in sidebar screen #6558

  • QA
  • Accessibility

• #6547 add continious deletion of IOU amount on long press #6626

  • QA
  • Accessibility

• Open modal to join screen share requests from GuidesPlus agents #6654

  • QA
  • Accessibility

• Refactor uses of react-native Text to ExpensifyText #6658

  • QA
  • Accessibility

• make workspace message scrollable #6695

  • QA
  • Accessibility

• Show Empty Chat with draft messages in LHN #6698

  • QA
  • Accessibility

• Add comment when update protected branch fails #6706

  • QA
  • Accessibility

• Add some hitSlop around the send button #6708

  • QA
  • Accessibility

• Clean Old password when user click goBack #6723

  • QA
  • Accessibility

• [CP Staging] Fix same name policy rooms and policy room title and mobile app crashing when creating policy room #6724

  • QA
  • Accessibility

• Fix inverted list by applying forked version of react-native-web #6738

  • QA
  • Accessibility

• Update getSimplifiedPolicyObject to handle different policy objects #6739

  • QA
  • Accessibility

• Fix app crashes tapping the room name in the chat #6741

  • QA
  • Accessibility

• Make sure that we reduce the unread message count when we delete an unread message #6746

  • QA
  • Accessibility

• Made keyboard shortcut modal unswipeable #6753

  • QA
  • Accessibility

• Trim Login value before validating it on LoginForm #6771

  • QA
  • Accessibility

Internal QA:

• Update "Additional details" form in KYC wallet upgrade flow #6752 - @marcaaron

Deploy Blockers:

• Android/iOS - New room - Messages appear at the top of the page in chat room #6792
• Android - There is no unread message indicator appears for the app  #6799

cc @Expensify/applauseleads

[MelvinBot]

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mvtglobally]

Starting QA

[Julesssss]

The 'New room - Messages appear at the top of the page in chat room ' blocker should now have been fixed with this PR. It was cherry-picked to staging: #6798

[Julesssss]

I closed the second blocker and checked it off, as the unread indicator feature isn't implemented on Android.

[mvtglobally]

Regression is almost complete. We will update rest of the PRs

Comments added

• Open modal to join screen share requests from GuidesPlus agents #6654 (comment)
• Clean Old password when user click goBack #6723 (comment)

Issues logged:

• Android/iOS - New room - Messages appear at the top of the page in chat room #6792
• Android - There is no unread message indicator appears for the app  #6799

[mvtglobally]

checking off #6723 based on this #6723 (comment)

[mvtglobally]

Checking off #6792 its a pass

[mvtglobally]

@roryabraham @Julesssss I think we are good to close this checklist.

[roryabraham]

I am going to hold off and let @Julesssss handle it this time 😉

[Julesssss]

Thanks @mvtglobally & @roryabraham!

[Julesssss]

[OSBotify]

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[Julesssss]

Let me try again, I think I had not yet removed the deployBlocker label from all issues.

[Julesssss]

[OSBotify]

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[Julesssss]

Okay, so it looks like this PR was added since logging off last night.

[Julesssss]

I see, we have a new InternalQA label for NewDot. @nickmurray47 is assigned to review the PR, but if I get through all my other tasks for the day I will take over.

[roryabraham]

@Julesssss you also need to check off all the accessibility checkboxes.

[Julesssss]

Checking off the stagingQA PR as the feature isn't yet live and we will have more testing before releasing the feature.

[Julesssss]

[Julesssss]

I was so excited to release that I forgot it was Friday afternoon 😬

I'll follow the release, hopefully App Review will add some delay.