[HOLD for payment 2022-05-20][$500] Some image and video downloads do not get stored in Photo Gallery in iOS - Reported by @mananjadhav

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open app.
2. Send specific image to chat (link below)
3. Download this image from another chat

Expected Result:

Images should go to Photo gallery on IOS

Actual Result:

Some specific images go to Files instead of photo gallery. Issue is not repro with all the images

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

download-attachment.MP4

Expensify/Expensify Issue URL:
Issue reported by: @mananjadhav
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642005135378900

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

I don't have an IPhone to reproduce this locally, but the issue looks well described.

[MelvinBot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

Posted!

Internal - https://www.upwork.com/ab/applicants/1483987676649086976/job-details
External - https://www.upwork.com/jobs/~01d1d7546259125a4f

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[wenge8n]

This issue is an expected behavior because rn-fetch-blob doesn't save file in photo library by default in iOS.
Currently we download file into dirs.DocumentDir folder in iOS and the file will be saved in the app's sandbox storage (documentDirectory).

Proposal

After download file(image/video) in iOS, we need to copy/move file to photo library by manually.
For image/video, we can download them into cache directory dirs.CacheDir if you don't want duplication. For more info
We can copy the image/video into photo library using react-native-cameraroll

So the steps are

1. Download file into document or cache directory
2. Copy file into photo library

This is only for image/video in iOS. For other cases, we will stay on the current logic.

[rushatgabhane]

because rn-fetch-blob doesn't save file in photo library by default in iOS.

@wenge8n hmm, from the slack thread - we can save most to photo library in iOS except the likes of images in the issue.

The solution you're proposing looks like a workaround. I'd prefer if we find and fix the root cause.
What do you think?

[wenge8n]

I don't have access to the slack channel so I sent request to join slack and am waiting now.

we can save most to photo library in iOS except the likes of images in the issue

Hmm.. so you mean it works sometimes and it doesn't work sometimes?
I tested it and the files are always saved in the document directory. They never saved in the photo library.
Because as I said rn-fetch-blob doesn't support such functionality.

[rushatgabhane]

so you mean it works sometimes and it doesn't work sometimes

Yep

I tested it and the files are always saved in the document directory. They never saved in the photo library. Because as I said rn-fetch-blob doesn't support such functionality.

Okay, the issue reporter also faced the same thing; all photos stored in document. Whilst others can save photos to their gallery except the ones mentioned in this issue.

[robert-go]

Hi, I'm from Upwork
I'm on the main branch, am I on the right branch?
Because it save the image to Document only
I can't save images on my iPhone
I also don't see the app asking for any permission to save the photo

[rushatgabhane]

Hey @robert-go, yes you're on the right branch.

From slack - "I'm on v1.1.26-1 on iOS app, downloaded a .png file and it went to photo gallery. "
"Can confirm that when I downloaded those two images (attached in the issue) they went to files and not photo gallery, not sure why"

Likewise for me, images are saved to gallery. But the ones mentioned in the issue are saved to documents 😵

[mananjadhav]

@thienlnam PR updated.

[thienlnam]

Just merged, now waiting for deploys and regression tests

[dylanexpensify]

I'm heading on parental leave so reassigning! Thank you to whoever gets assigned this! ❤️

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thienlnam]

Same as above, waiting for deploy and production wait

[thienlnam]

Same as above, just recently deployed to staging - latest deploy updates here

[mananjadhav]

@thienlnam @JmillsExpensify This went to production 3 days back, but the payment date wasn't updated.

[JmillsExpensify]

Cool, thanks for the heads up. Checking the linked PR and then I'll update the issue title. Actually nevermind, @thienlnam already got it!

[mananjadhav]

@JmillsExpensify Bump on Upwork. Here I am the reporter and the contributor both.

[JmillsExpensify]

Thanks! I'm jumping over to Upwork now to issue payment and close this one out for everyone.

[JmillsExpensify]

Payments processed for @mananjadhav (reporting and PR), as well as @parasharrajat (C+). Closing the issue. Please comment in this issue with any further questions!