Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for isFormInput prop in Form #7755

Closed
luacmartins opened this issue Feb 15, 2022 · 6 comments
Closed

Remove the need for isFormInput prop in Form #7755

luacmartins opened this issue Feb 15, 2022 · 6 comments
Assignees
Labels

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 15, 2022

Problem

Right now we use a isFormInput prop to decide when to pass form props to a child component. There's a disconnect between the name and purpose of this prop, which can be confusing. We could make this implementation simpler and remove the need for isFormInput altogether.

Why is this important

It makes the code less confusing and DRY, simplifying the usage of form inputs.

Solution

  1. Figure out some logic to automatically pass form props to inputs only, i.e. excluding View, Text, ScrollView, etc.
  2. Remove all usages of isFormInput from the code base.
@luacmartins luacmartins added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Feb 15, 2022
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Feb 15, 2022
@luacmartins luacmartins added AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering labels Feb 15, 2022
@MelvinBot
Copy link

Current assignee @Christinadobrzyn is eligible for the AutoAssignerTriage assigner, not assigning anyone new.

@luacmartins luacmartins removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Feb 15, 2022
@luacmartins luacmartins self-assigned this Feb 15, 2022
@luacmartins luacmartins removed the Daily KSv2 label Feb 15, 2022
@luacmartins
Copy link
Contributor Author

We are waiting to work on this after the Form refactors are done, so it doesn't confuse contributors.

@MelvinBot MelvinBot removed the Overdue label Mar 18, 2022
@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2022
@luacmartins
Copy link
Contributor Author

Still waiting for refactors to be done.

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2022
@luacmartins
Copy link
Contributor Author

Gonna start working on this now that Form input refactors are done!

@luacmartins luacmartins added Weekly KSv2 and removed Monthly KSv2 labels Apr 28, 2022
@luacmartins
Copy link
Contributor Author

Working on this today!

@luacmartins luacmartins mentioned this issue May 5, 2022
84 tasks
@luacmartins luacmartins added the Reviewing Has a PR in review label May 11, 2022
@melvin-bot melvin-bot bot closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants