-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need for isFormInput
prop in Form
#7755
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Current assignee @Christinadobrzyn is eligible for the AutoAssignerTriage assigner, not assigning anyone new. |
We are waiting to work on this after the Form refactors are done, so it doesn't confuse contributors. |
Still waiting for refactors to be done. |
Gonna start working on this now that Form input refactors are done! |
Working on this today! |
Problem
Right now we use a
isFormInput
prop to decide when to pass form props to a child component. There's a disconnect between the name and purpose of this prop, which can be confusing. We could make this implementation simpler and remove the need forisFormInput
altogether.Why is this important
It makes the code less confusing and DRY, simplifying the usage of form inputs.
Solution
View
,Text
,ScrollView
, etc.isFormInput
from the code base.The text was updated successfully, but these errors were encountered: