[HOLD for payment 2022-05-20][$250] Update Form.md with the correct input character counter and enter press behavior

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

The Form.md doc is outdated. In particular, the sections below:

1. https://github.com/Expensify/App/blob/main@%7B2022-04-12T19:03:07Z%7D/FORMS.md#character-limits - this feature was removed for now
   2.Additionally, ressing the enter key on any focused field should submit the form. - we should add an exception for a multiline input.

Expected Result:

The doc should be up to date and inputs.

Actual Result:

Doc is outdated.

Workaround:

Ignore the outdated sections of the doc.

Platform:

Where is this issue occurring?

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation:

View all open jobs on GitHub

Upwork Job https://www.upwork.com/jobs/~0126ebd7bae5f2670c

[melvin-bot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Puneet-here]

Hi, I can update it.

[Puneet-here]

We can make these changes:-

Character Limits

If a field has a character limit we should give that field a max limit. This is done by passing the maxLength prop to TextInput.

<TextInput
    maxLength={20}
/>

Note: We shouldn't place a max limit on a field if the entered value can be formatted. eg: Phone number.
The phone number can be formatted in different ways

• 2109400803
• +12109400803
• (210)-940-0803

App/FORMS.md

Line 69 in fd23073

Additionally, ressing the enter key on any focused field should submit the form.

we can add another line here:

Note: This doesn't apply to the multiline fields, pressing enter on multiline fields shouldn't submit the form

[luacmartins]

Your proposal looks good @Puneet-here!

[luacmartins]

@Puneet-here please apply to the job in Upwork once it's exported.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

@Puneet-here's proposal looks good here. I don't think C+ is needed for such an issue but I am fine with reviewing the PR.

cc: @Julesssss

🎀 👀 🎀 C+ reviewed

[melvin-bot]

📣 @Puneet-here You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Julesssss]

I think we still need the UpWork job to be created first? But yep, the proposal looks good.

[Puneet-here]

I have applied to the upwork job.
Thanks.

I am now hired on upwork.

[Puneet-here]

I have raised the PR.
Thanks.

[Julesssss]

PR merged, awaiting deploy

[Julesssss]

We're still awaiting deploy, had a couple of issues this week but it should occur pretty soon now.

[Julesssss]

@kevinksullivan this one is good for payment 👍

[kevinksullivan]

Paid @Puneet-here . Job was closed so I reposted a new one to cover C+ @parasharrajat here. Please let me know when you accept and I'll handle that payment!

[parasharrajat]

@kevinksullivan Accepted it.

[parasharrajat]

@kevinksullivan Bump.

[luacmartins]

@parasharrajat Kevin is ooo until Monday. Let me know if this can't wait and I'll assign another CM.

[kevinksullivan]

All set thanks for your patience @parasharrajat .