[$250 - Payment Due 9/28] IOS - Payments - The button "Add payment method" is not visible when scrolled up

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Log in any account
3. Setting< Payments
4. Scroll up the app

Expected Result:

The button "Add payment method" is visible when scrolled up

Actual Result:

The button "Add payment method" is not visible when scrolled up

Workaround:

Uknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.57.12

Reproducible in staging?: Yes

Reproducible in production?: No (new feature)

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5566351_button_1005.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

https://www.upwork.com/jobs/~01d4896d71392866b8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

Does not seem like an real issue. As soon as the user leaves the scroll, button moves to the bottom.

[roryabraham]

I feel like the button should just be outside the scrollview and anchored to the bottom of the page

[JosueEchandiaAsto]

@parasharrajat

Proposal

Issue

Extra space displayed when used non-quoted and quoted than non-quoted text. (Android and iOS)

Fix

Scrollable elements in iOS have a bounce property, setting this to false disables this behavior.
bounces={false} to FlatList in PaymentMethodList.

Commit: main...JosueEchandiaAsto:Fix-Issue-8929

[parasharrajat]

Extra space displayed when used non-quoted and quoted than non-quoted text. (Android and iOS)

How is this related?

Also, I don't like the proposed solution.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

@MitchExpensify 👋 am OOO til 12 August so reassigning. Thanks!

[MitchExpensify]

Enjoy @laurenreidexpensify !

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[MitchExpensify]

Do we need to move forward with the PR if the issue not reproducible?

[roryabraham]

@MitchExpensify it might depend on what iOS device is used. I think we should move forward with the PR for the sake of code consistency and cleanup too. @JosueEchandiaAsto when can we expect an update?

[mananjadhav]

@JosueEchandiaAsto Please update on the PR. We've waited for more than 3 weeks now for an update now.

[mananjadhav]

@JosueEchandiaAsto We've sent multiple reminders on the PR and here. Please send us an update on the PR by Monday EOD? Otherwise we'll have to rescind the job.

cc - @roryabraham @MitchExpensify

[MitchExpensify]

Good call @mananjadhav. Lets now move to rescind the job without update from @JosueEchandiaAsto after the bump above. I'll double the price and post to Slack once we've rescinded it

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[MitchExpensify]

Scratch the doubling next step.. this hasn't been reproducible for 2 weeks - closing

[mananjadhav]

@MitchExpensify Afaik the issue is reproducible on smaller devices. Also the Add Payment Button is inconsistent with the rest of the UIs where we dock the button at the bottom.

[JosueEchandiaAsto]

Oh, I'm so sorry!. I was focused on other projects, and I think I accidentally disabled issue notifications.
If that's all right, I want to finish this develop and send a PR update in tomorrow for review.

[MitchExpensify]

@JosueEchandiaAsto do you have an update on the PR?

[JosueEchandiaAsto]

@roryabraham Requested changes are done #9622

[mananjadhav]

Thanks @JosueEchandiaAsto let me take a look at it today.

[JosueEchandiaAsto]

Again, sorry for the delay. I will be pending so that this issue can be fixed as soon as possible

[mananjadhav]

An update here, PR is reviewed from C+, should be merged soon

[mananjadhav]

This was deployed to production 2 days back, but no automation comment on the merge here in the issue? And no update on payment date too.

cc - @MitchExpensify @roryabraham

[MitchExpensify]

Good catch @mananjadhav! I've made a note to check for regressions on Wednesday before issuing payment

[MitchExpensify]

Still saying "6 days" on the merge to prod so holding until it hits 7

[MitchExpensify]

Paid & contracts ended! Thanks everyone