Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login- Error is not highlighted in red when typing a password not meet the requirements #8968

Closed
kbecciv opened this issue May 12, 2022 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented May 12, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Start typing a new email account
  3. Click Continue
  4. Go back to your email and tap on link
  5. Fill the password field with a value that does not comply with the rules
  6. Click on "Set Password" button

Expected Result:

The message below the field where the password is entered should be highlighted in red

Actual Result:

The message below the field is not highlighted in red when a password that does not meet the requirements is entered

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.57.15

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5568725_Forgot_New_Password-1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label May 12, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2022

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@bondydaa
Copy link
Contributor

yep def broken, it might be related to this as well #8440 cc @NikkiWines @parasharrajat should we combine these 2, I have idea if it's the same code or not but probably should be or at least have the same behaviors.

@bondydaa bondydaa removed their assignment May 12, 2022
@thesahindia
Copy link
Member

thesahindia commented May 12, 2022

@bondydaa, I don't think it's related to #8440, also this isn't an issue we keep the "Set password" button disabled until user enters a valid password, so basically there's no way for the user to submit a password like this.

Right now the button stays enabled because of the regression from #8680 and it already got logged here so we can close this one.

@bondydaa
Copy link
Contributor

coolio closing, dupe of #8962

@bondydaa bondydaa self-assigned this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants