Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older report comments are not loaded once we scroll to the top - reported by @santhosh-sellavel #8994

Closed
chiragsalian opened this issue May 13, 2022 · 13 comments
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@chiragsalian
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Click on any search that contains a good amount of history.
  3. Scroll up to the top.

Expected Result:

Once we reach the top more comments should have loaded.

Actual Result:

No comments are loaded once we scroll to the top. So for a chat we can only see around 50-100 comments and not more.

Workaround:

Unkown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.60-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://expensify.slack.com/archives/C01GTK53T8Q/p1652463943094999

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1652463943094999

View all open jobs on GitHub

@chiragsalian chiragsalian added DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 13, 2022
@chiragsalian
Copy link
Contributor Author

cc @thesahindia

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 13, 2022

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian
Copy link
Contributor Author

Its being worked on here

@michaelhaxhiu michaelhaxhiu changed the title Older report comments are not loaded once we scroll to the top Older report comments are not loaded once we scroll to the top - reported by @santhosh-sellavel May 13, 2022
@thesahindia
Copy link
Member

thesahindia commented May 13, 2022

PR is up #9001.

@chiragsalian chiragsalian mentioned this issue May 13, 2022
89 tasks
@melvin-bot melvin-bot bot closed this as completed May 13, 2022
@chiragsalian chiragsalian added the External Added to denote the issue can be worked on by a contributor label May 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 13, 2022

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels May 13, 2022
@chiragsalian chiragsalian added the Reviewing Has a PR in review label May 13, 2022
@chiragsalian
Copy link
Contributor Author

chiragsalian commented May 13, 2022

PR has been merged
@michaelhaxhiu, feel free to compensate @Santhosh-Sellavel for finding the issue and @thesahindia for helping resolve the issue when appropriate.

@chiragsalian chiragsalian reopened this May 13, 2022
@chiragsalian
Copy link
Contributor Author

Reopening since i'll ask QA to test when this is on staging.

@chiragsalian chiragsalian self-assigned this May 13, 2022
@roryabraham
Copy link
Contributor

Looks like this passed QA

@michaelhaxhiu
Copy link
Contributor

PR has been merged @michaelhaxhiu, feel free to compensate @Santhosh-Sellavel for finding the issue and @thesahindia for helping resolve the issue when appropriate.

Yep! So here's what we should have:

@Santhosh-Sellavel - $250 for reporting the bug
@thesahindia - $250 for assisting in finding/fixing the deploy blocker

Can you both please apply to the upwork job here

@Santhosh-Sellavel
Copy link
Collaborator

Applied, thanks!

@thesahindia
Copy link
Member

Done ✅

@michaelhaxhiu
Copy link
Contributor

Paid both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants