[HOLD for payment 2022-06-21] [$250] Android - Close account - Email address in default contact method is split in two lines instead of under the text "Default contact method"

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app and login with public domain email
2. Go to Settings > Security > Close account
3. Observe the default contact method section

Expected Result:

Email address / phone number should appear below "Default contact method"

Actual Result:

Email address appears split in two lines unlike other environments

Workaround:

Visual

Platform:

Where is this issue occurring?

• Android

Version Number: 11.69-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

**Upwork URL:** https://www.upwork.com/jobs/~018b99730f8f9ca365 **Issue reported by:** Applause internal tester **Slack conversation:**

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

Proposal

We can use textBreakStrategy here.
just need to pass textBreakStrategy="simple" or "balanced" to Text

App/src/pages/settings/Security/CloseAccountPage.js

Line 89 in db27a3d

<Text style={[styles.mt5]}>

[melvin-bot]

@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @Luke9389 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

Oh weird, not sure why Melv assigned this to me while I was OOO.

Job is on Upwork here: https://www.upwork.com/jobs/~018b99730f8f9ca365

[parasharrajat]

@thesahindia What about other platforms? That prop only works on Android.

[thesahindia]

@parasharrajat, the issue is for android only. It works fine at other platforms.

[parasharrajat]

Ok, then what value are you suggesting to pass and what is the effect of it?

[thesahindia]

We can pass textBreakStrategy="simple". The default value is highQuality and because of that it breaks, if we use simple or balanced in will take the next line.

[thesahindia]

Issue not reproducible during KI retests. (First week)

The issue is still reproducible.

[parasharrajat]

Can I get a screenshot to see the difference that it will make? I ran a few general tests and there was no change for me.

[thesahindia]

Before

After

Note: The email needs to contain full stop to repro this issue.

[parasharrajat]

Ok, looking good to me. @thesahindia 's proposal LGTM.

cc: @Luke9389

🎀 👀 🎀 C+ reviewed

[Luke9389]

Alright @thesahindia go ahead and make a PR!

[melvin-bot]

📣 @thesahindia You have been assigned to this job by @trjExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[thesahindia]

PR is up.

[parasharrajat]

PR is approved

[mvtglobally]

During retest, team noticed the following. Is this expected as per new design? https://utest-dl.s3.amazonaws.com/testRunStepMinAttachmentsResult/21462995/and_9229-1106.jpg?AWSAccessKeyId=AKIAJ2UIWMJ2OMC3UCQQ&Expires=1686717416&Signature=M7niYpBeC4TMH%2BgPiV4k2gTw6%2Fc%3D

[thesahindia]

It was designed this way and it's expected.
cc: @parasharrajat @Luke9389

[parasharrajat]

Yeah, it is expected as per my knowledge.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.76-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix the breaking of email at close account page #9400

If no regressions arise, payment will be issued on 2022-06-21. 🎊

[trjExpensify]

Settled up with @thesahindia, @parasharrajat waiting for you to accept the invite for C+.

[trjExpensify]

Paid @parasharrajat now. Closing.

[parasharrajat]

@trjExpensify I have accepted the offer.