[HOLD for payment 2022-08-30] [$1000] Attachment - Image file size gets doubled when uploaded from iOS @aswin-s

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Go to a chat and upload an image from a mobile device.
3. Check the image size on device.
4. Now open the chat on recipient account in a web browser.
5. Open and download the received image.
6. Check the image file size. It is almost double the original file size

Expected Result:

File size should be at least equal or less than the uploaded size.

Actual Result:

Image file size gets doubled when uploaded from mobile.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.76.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.Bug.mp4

Expensify/Expensify Issue URL:

Issue reported by: @aswin-s

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1654070862340069

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[yuwenmemon]

Note: this is only happening for JPEG filetypes.

[yuwenmemon]

Looks like the filesize is getting adjusted client-side:

Kapture.2022-06-28.at.14.58.49.mp4

[yuwenmemon]

Anywhooo... Looks like since this is not a problem with the API we can have a contributor work on it. Curious to know what the issue is!

[melvin-bot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[kadiealexander]

Posted to Upwork!

https://www.upwork.com/jobs/~01b7fcbbd791dc6c42
https://www.upwork.com/ab/applicants/1532271886227472384/job-details

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[ntdiary]

@mountiny react-native-image-picker/react-native-image-picker#2006 🙂

[mountiny]

Bumped the maintainer of the repo for a review 🤞

[Santhosh-Sellavel]

Has melvin gone crazy?

[mountiny]

No, this is a new feature when you comment linking an issue or PR in deployBlocker

[Santhosh-Sellavel]

Ya but when this issue doesn't have any active or merged PR, notification doesn't make any sense.

[mountiny]

@Santhosh-Sellavel That is true we cant really see if there is a linked PR to this issue, but I think we might want to look into this, maybe checking if the issue has Awaiting Payment label signalling the linked PR has been closed or is closed in general as internal issues wont have Awaiting Payment.

[mountiny]

@ntdiary Your PR has been merged and released! 🎉 lets move ahead with testing this in our App :) thank you!

[ntdiary]

Hi, @mountiny I've submitted a PR, please let me know if I'm not doing something right 😄

[Santhosh-Sellavel]

@Santhosh-Sellavel That is true we cant really see if there is a linked PR to this issue, but I think we might want to look into this, maybe checking if the issue has Awaiting Payment label signalling the linked PR has been closed or is closed in general as internal issues wont have Awaiting Payment.

Maybe let's use the Reviewing Label is common to internal or external right?

[mountiny]

Maybe let's use the Reviewing Label is common to internal or external right?

We are discussing this, the internal ones get closed when issue is merged.

[Santhosh-Sellavel]

We are discussing this, the internal ones get closed when the issue is merged.

Cool, we can ask melvin to reopen it if that's not a problem. Like it does for crash issues.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.88-15 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix image file size when uploaded from ios #10297

If no regressions arise, payment will be issued on 2022-08-30. 🎊

[kadiealexander]

@aswin-s and @ntdiary have been paid, thank you!

@Santhosh-Sellavel please let me know once you've accepted the contract and I'll issue payment here too.

[Santhosh-Sellavel]

Done @kadiealexander thanks!

[kadiealexander]

Thanks Santhosh! Paid you as well.