Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll to make sure PR checks are finished before giving up in isPullRequestMergeable #9640

Closed
roryabraham opened this issue Jun 30, 2022 · 0 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

Problem

We've seen a few workflows like this where a PR enters mergeable_state === 'blocked', and isPullRequestMergeable gives up and determines that there's a problem and the PR can't be merged. Only moments later, the PR becomes mergeable.

I believe this is a race condition, because the verifySignedCommits PR check is running, and while the PR checks are ongoing the PR is in mergeable_state === 'blocked'. Sometimes verifySignedCommits finishes in less that 10 seconds and so the polling mechanism doesn't recheck the PR until it's done.

Solution

Poll the PR checks and make sure they're done before giving up due to mergeable_state === 'blocked'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

1 participant