[HOLD #9660] [$250] Copy link option is shown for app links - Reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:9

1. Go to settings > About > app download links
2. Right click on a link

Expected Result:

Copy link option shouldn't be shown

Actual Result:

We have an option to copy link

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1656846795990329

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

I think the whole menu should not be shown. Good catch @thesahindia

[laurenreidexpensify]

Just so I understand better, can you explain a bit more why you think this is a problem @thesahindia @parasharrajat ? I'm thinking that maybe we would want to give users the option to cut the URL and be able to share it to help us with virality?

[parasharrajat]

There are two things here:

1. First, the copy link option on the menu should not be present for links. This is not meant for these links.
2. Why is this menu popping up for app menu items? I am not sure if this was done intentionally but as per my knowledge, it was not the case a few months back.

---

OK, I can confirm 2 is intentional as per the #9047. But 1 is still an issue.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[NikkiWines]

Able to reproduce on staging and looks fine for a contributor to pick up. Adding External

[melvin-bot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[NikkiWines]

Oops sorry @stephanieelliott didn't mean to unassign you

[stephanieelliott]

Posted to Upwork: https://www.upwork.com/jobs/~0115c0cba0d60a784f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Triggered auto assignment to @flodnv (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[stephanieelliott]

Hey @thesahindia, as the reporter of this issue you have first dibs on the job! Please post a proposal if you have one.

[vladnyk]

Proposal

Option 1: whole menu should not be shown

App/src/pages/settings/AppDownloadLinks.js

Line 88 in bfbdd4e

onSecondaryInteraction={e => showPopover(e, item.link)}

remove this line

Option 2: Copy link should not be shown. Copy URL to clipboard can still be shown

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 124 in bfbdd4e

shouldShow: () => true,

replace this line with:

        shouldShow: type => type !== CONTEXT_MENU_TYPES.LINK,

[parasharrajat]

This is kind of a duplicate as the solution we are working for #9660 in PR #9955 will fix this.

As #9660 was created first and being resolved at the moment, we can close this issue.

[Santhosh-Sellavel]

Thanks, @parasharrajat!

@flodnv
Let's remove help wanted here and wait for #9660's PR to be merged.
Once PR is merged, lets verify and close this one until then let's add On hold for 9660 to issue title.

[flodnv]

Agreed & done, thanks!

[stephanieelliott]

No update, moving this to monthly while it's on hold!

[stephanieelliott]

#9660 PR was merged, just tested and this issue is no longer occurring. Closing this one out!