-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host our own PDF viewer instead of using Mozilla demo page #878
Conversation
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
|
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
1 similar comment
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, a lot simpler than the diff would suggest. The actual code changes LGTM.
Only NAB I had was wondering if all these pdf properties files could be gitingored and generated on build or something since there are so many. But if that seems overly complicated feel free to merge!
Yeah I brought this up in |
cc @thienlnam
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/146082
Tests
Screenshots
❌