Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add a configuration option to unsubscribe for some keys for StorageEvent across tabs #127

Closed
mdneyazahmad opened this issue Apr 23, 2022 · 3 comments
Closed

[Feat] Add a configuration option to unsubscribe for some keys for StorageEvent across tabs #127

mdneyazahmad opened this issue Apr 23, 2022 · 3 comments

Comments

@mdneyazahmad
Copy link
Contributor

Problem

When user opens multiple tabs with different reports. We do not want some data in onyx to sync across tabs.

Proposed Solution

We will add a property keysToDisableSyncEvents an array with keys on configuration object for Onyx.init. It will prevent syncing for these keys when StorageEvent is fired.

suggested by: @marcaaron

comming from pr Expensify/App#8227
@mdneyazahmad mdneyazahmad mentioned this issue Apr 23, 2022
Merged
@Beamanator
Copy link
Contributor

Note: The exact comment when this was suggested is here: Expensify/App#8227 (comment)

@mdneyazahmad
Copy link
Contributor Author

@Beamanator We should close this issue as related issue on Expensify/App is fixed and closed.

@Beamanator
Copy link
Contributor

Agreed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Beamanator @mdneyazahmad